Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 690713003: Assert that unoptimized code does not embed context-specific objects. (Closed)

Created:
6 years, 1 month ago by Yang
Modified:
6 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Assert that unoptimized code does not embed context-specific objects. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25029

Patch Set 1 #

Patch Set 2 : do not allow objects from builtins context #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M src/full-codegen.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/objects-debug.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 1 month ago (2014-10-29 15:44:40 UTC) #1
Toon Verwaest
lgtm
6 years, 1 month ago (2014-10-31 09:23:21 UTC) #2
Yang
6 years, 1 month ago (2014-10-31 09:31:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 25029 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698