Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: cc/resources/resource_provider.cc

Issue 690713002: cc: check valid thread and resource origin for the resource rasterized. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove redundant DCHECK_IS_ON Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/resources/resource_provider.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/resources/resource_provider.h" 5 #include "cc/resources/resource_provider.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <limits> 8 #include <limits>
9 9
10 #include "base/containers/hash_tables.h" 10 #include "base/containers/hash_tables.h"
(...skipping 710 matching lines...) Expand 10 before | Expand all | Expand 10 after
721 DCHECK_EQ(Bitmap, resource->type); 721 DCHECK_EQ(Bitmap, resource->type);
722 delete resource->shared_bitmap; 722 delete resource->shared_bitmap;
723 resource->pixels = NULL; 723 resource->pixels = NULL;
724 } 724 }
725 if (resource->pixels) { 725 if (resource->pixels) {
726 DCHECK(resource->origin == Resource::Internal); 726 DCHECK(resource->origin == Resource::Internal);
727 delete[] resource->pixels; 727 delete[] resource->pixels;
728 resource->pixels = NULL; 728 resource->pixels = NULL;
729 } 729 }
730 if (resource->gpu_memory_buffer) { 730 if (resource->gpu_memory_buffer) {
731 DCHECK(resource->origin != Resource::External); 731 DCHECK(resource->origin == Resource::Internal);
732 delete resource->gpu_memory_buffer; 732 delete resource->gpu_memory_buffer;
733 resource->gpu_memory_buffer = NULL; 733 resource->gpu_memory_buffer = NULL;
734 } 734 }
735 resources_.erase(it); 735 resources_.erase(it);
736 } 736 }
737 737
738 ResourceProvider::ResourceType ResourceProvider::GetResourceType( 738 ResourceProvider::ResourceType ResourceProvider::GetResourceType(
739 ResourceId id) { 739 ResourceId id) {
740 return GetResource(id)->type; 740 return GetResource(id)->type;
741 } 741 }
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
1023 ResourceProvider* resource_provider, 1023 ResourceProvider* resource_provider,
1024 ResourceProvider::ResourceId resource_id) 1024 ResourceProvider::ResourceId resource_id)
1025 : resource_provider_(resource_provider), 1025 : resource_provider_(resource_provider),
1026 resource_(resource_provider->LockForWrite(resource_id)) { 1026 resource_(resource_provider->LockForWrite(resource_id)) {
1027 ResourceProvider::PopulateSkBitmapWithResource(&sk_bitmap_, resource_); 1027 ResourceProvider::PopulateSkBitmapWithResource(&sk_bitmap_, resource_);
1028 DCHECK(valid()); 1028 DCHECK(valid());
1029 sk_canvas_.reset(new SkCanvas(sk_bitmap_)); 1029 sk_canvas_.reset(new SkCanvas(sk_bitmap_));
1030 } 1030 }
1031 1031
1032 ResourceProvider::ScopedWriteLockSoftware::~ScopedWriteLockSoftware() { 1032 ResourceProvider::ScopedWriteLockSoftware::~ScopedWriteLockSoftware() {
1033 DCHECK(thread_checker_.CalledOnValidThread());
1033 resource_provider_->UnlockForWrite(resource_); 1034 resource_provider_->UnlockForWrite(resource_);
1034 } 1035 }
1035 1036
1036 ResourceProvider::ScopedWriteLockGpuMemoryBuffer:: 1037 ResourceProvider::ScopedWriteLockGpuMemoryBuffer::
1037 ScopedWriteLockGpuMemoryBuffer(ResourceProvider* resource_provider, 1038 ScopedWriteLockGpuMemoryBuffer(ResourceProvider* resource_provider,
1038 ResourceProvider::ResourceId resource_id) 1039 ResourceProvider::ResourceId resource_id)
1039 : resource_provider_(resource_provider), 1040 : resource_provider_(resource_provider),
1040 resource_(resource_provider->LockForWrite(resource_id)), 1041 resource_(resource_provider->LockForWrite(resource_id)),
1041 gpu_memory_buffer_manager_(resource_provider->gpu_memory_buffer_manager_), 1042 gpu_memory_buffer_manager_(resource_provider->gpu_memory_buffer_manager_),
1042 gpu_memory_buffer_(nullptr), 1043 gpu_memory_buffer_(nullptr),
1043 size_(resource_->size), 1044 size_(resource_->size),
1044 format_(resource_->format) { 1045 format_(resource_->format) {
1045 DCHECK_EQ(GLTexture, resource_->type); 1046 DCHECK_EQ(GLTexture, resource_->type);
1046 std::swap(gpu_memory_buffer_, resource_->gpu_memory_buffer); 1047 std::swap(gpu_memory_buffer_, resource_->gpu_memory_buffer);
1047 } 1048 }
1048 1049
1049 ResourceProvider::ScopedWriteLockGpuMemoryBuffer:: 1050 ResourceProvider::ScopedWriteLockGpuMemoryBuffer::
1050 ~ScopedWriteLockGpuMemoryBuffer() { 1051 ~ScopedWriteLockGpuMemoryBuffer() {
1052 DCHECK(thread_checker_.CalledOnValidThread());
1051 resource_provider_->UnlockForWrite(resource_); 1053 resource_provider_->UnlockForWrite(resource_);
1052 if (!gpu_memory_buffer_) 1054 if (!gpu_memory_buffer_)
1053 return; 1055 return;
1054 1056
1055 if (!resource_->image_id) { 1057 if (!resource_->image_id) {
1056 GLES2Interface* gl = resource_provider_->ContextGL(); 1058 GLES2Interface* gl = resource_provider_->ContextGL();
1057 DCHECK(gl); 1059 DCHECK(gl);
1058 1060
1059 resource_->image_id = 1061 resource_->image_id =
1060 gl->CreateImageCHROMIUM(gpu_memory_buffer_->AsClientBuffer(), 1062 gl->CreateImageCHROMIUM(gpu_memory_buffer_->AsClientBuffer(),
(...skipping 25 matching lines...) Expand all
1086 } 1088 }
1087 1089
1088 ResourceProvider::ScopedWriteLockGr::ScopedWriteLockGr( 1090 ResourceProvider::ScopedWriteLockGr::ScopedWriteLockGr(
1089 ResourceProvider* resource_provider, 1091 ResourceProvider* resource_provider,
1090 ResourceProvider::ResourceId resource_id) 1092 ResourceProvider::ResourceId resource_id)
1091 : resource_provider_(resource_provider), 1093 : resource_provider_(resource_provider),
1092 resource_(resource_provider->LockForWrite(resource_id)) { 1094 resource_(resource_provider->LockForWrite(resource_id)) {
1093 } 1095 }
1094 1096
1095 ResourceProvider::ScopedWriteLockGr::~ScopedWriteLockGr() { 1097 ResourceProvider::ScopedWriteLockGr::~ScopedWriteLockGr() {
1098 DCHECK(thread_checker_.CalledOnValidThread());
1096 resource_provider_->UnlockForWrite(resource_); 1099 resource_provider_->UnlockForWrite(resource_);
1097 } 1100 }
1098 1101
1099 SkSurface* ResourceProvider::ScopedWriteLockGr::GetSkSurface( 1102 SkSurface* ResourceProvider::ScopedWriteLockGr::GetSkSurface(
1100 bool use_distance_field_text) { 1103 bool use_distance_field_text) {
1104 DCHECK(thread_checker_.CalledOnValidThread());
1101 DCHECK(resource_->locked_for_write); 1105 DCHECK(resource_->locked_for_write);
1102 1106
1103 // If the surface doesn't exist, or doesn't have the correct dff setting, 1107 // If the surface doesn't exist, or doesn't have the correct dff setting,
1104 // recreate the surface within the resource. 1108 // recreate the surface within the resource.
1105 if (!resource_->sk_surface || 1109 if (!resource_->sk_surface ||
1106 use_distance_field_text != 1110 use_distance_field_text !=
1107 resource_->sk_surface->props().isUseDistanceFieldFonts()) { 1111 resource_->sk_surface->props().isUseDistanceFieldFonts()) {
1108 class GrContext* gr_context = resource_provider_->GrContext(); 1112 class GrContext* gr_context = resource_provider_->GrContext();
1109 // TODO(alokp): Implement TestContextProvider::GrContext(). 1113 // TODO(alokp): Implement TestContextProvider::GrContext().
1110 if (!gr_context) 1114 if (!gr_context)
(...skipping 1007 matching lines...) Expand 10 before | Expand all | Expand 10 after
2118 ContextProvider* context_provider = output_surface_->context_provider(); 2122 ContextProvider* context_provider = output_surface_->context_provider();
2119 return context_provider ? context_provider->ContextGL() : NULL; 2123 return context_provider ? context_provider->ContextGL() : NULL;
2120 } 2124 }
2121 2125
2122 class GrContext* ResourceProvider::GrContext() const { 2126 class GrContext* ResourceProvider::GrContext() const {
2123 ContextProvider* context_provider = output_surface_->context_provider(); 2127 ContextProvider* context_provider = output_surface_->context_provider();
2124 return context_provider ? context_provider->GrContext() : NULL; 2128 return context_provider ? context_provider->GrContext() : NULL;
2125 } 2129 }
2126 2130
2127 } // namespace cc 2131 } // namespace cc
OLDNEW
« no previous file with comments | « cc/resources/resource_provider.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698