WebThreadImplForMessageLoop to use blink scheduler

content/renderer/renderer_blink_platform_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/renderer_blink_platform_impl.h"
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
@@ skipping 210 matching lines @@
   // here.
   base::Lock unicode_font_families_mutex_;
   std::map<int32_t, blink::WebFallbackFont> unicode_font_families_;
 #endif
 };
 #endif  // defined(OS_ANDROID)
 
 //------------------------------------------------------------------------------
 
 RendererBlinkPlatformImpl::RendererBlinkPlatformImpl(
-    RendererScheduler* renderer_scheduler)
-    : web_scheduler_(new WebSchedulerImpl(renderer_scheduler)),
+    RendererScheduler* renderer_scheduler,
+    scoped_refptr<base::SingleThreadTaskRunner> main_thread_task_runner)
+    : BlinkPlatformImpl(main_thread_task_runner),

[rmcilroy, 2014/11/06 22:31:20]

Could we only have a renderer_scheduler as an argument to the constructor and
call BlinkPlatformImpl(renderer_scheduler->DefaultTaskRunner()) here instead?

[Sami, 2014/11/06 22:39:35]

Oh yeah, good idea.

[alex clarke (OOO till 29th), 2014/11/06 22:54:37]

Done.

[alex clarke (OOO till 29th), 2014/11/06 22:54:37]

Acknowledged.

+      web_scheduler_(new WebSchedulerImpl(renderer_scheduler)),
       clipboard_client_(new RendererClipboardClient),
       clipboard_(new WebClipboardImpl(clipboard_client_.get())),
       mime_registry_(new RendererBlinkPlatformImpl::MimeRegistry),
       sudden_termination_disables_(0),
       plugin_refresh_allowed_(true),
       default_task_runner_(renderer_scheduler->DefaultTaskRunner()),
       child_thread_loop_(base::MessageLoopProxy::current()),
       web_scrollbar_behavior_(new WebScrollbarBehaviorImpl),
       bluetooth_(new WebBluetoothImpl) {
   if (g_sandbox_enabled && sandboxEnabled()) {
     sandbox_support_.reset(new RendererBlinkPlatformImpl::SandboxSupport);
   } else {
     DVLOG(1) << "Disabling sandbox support for testing.";
   }
 
   // ChildThread may not exist in some tests.
   if (ChildThread::current()) {
     sync_message_filter_ = ChildThread::current()->sync_message_filter();
     thread_safe_sender_ = ChildThread::current()->thread_safe_sender();
     quota_message_filter_ = ChildThread::current()->quota_message_filter();
     blob_registry_.reset(new WebBlobRegistryImpl(thread_safe_sender_.get()));
     web_idb_factory_.reset(new WebIDBFactoryImpl(thread_safe_sender_.get()));
     web_database_observer_impl_.reset(
         new WebDatabaseObserverImpl(sync_message_filter_.get()));
   }
+
+  shared_timer_.SetTaskRunner(main_thread_task_runner_);

[Sami, 2014/11/06 22:20:44]

Couldn't we do this in the base class since we're already giving it the task
runner?

[alex clarke (OOO till 29th), 2014/11/06 22:28:34]

Done.

 }
 
 RendererBlinkPlatformImpl::~RendererBlinkPlatformImpl() {
   WebFileSystemImpl::DeleteThreadSpecificInstance();
 }
 
 //------------------------------------------------------------------------------
 
-void RendererBlinkPlatformImpl::callOnMainThread(void (*func)(void*),
-                                                 void* context) {
-  default_task_runner_->PostTask(FROM_HERE, base::Bind(func, context));
-}
-
 blink::WebScheduler* RendererBlinkPlatformImpl::scheduler() {
   return web_scheduler_.get();
 }
 
 blink::WebClipboard* RendererBlinkPlatformImpl::clipboard() {
   blink::WebClipboard* clipboard =
       GetContentClient()->renderer()->OverrideWebClipboard();
   if (clipboard)
     return clipboard;
   return clipboard_.get();
@@ skipping 943 matching lines @@
 //------------------------------------------------------------------------------
 
 void RendererBlinkPlatformImpl::MockBatteryStatusChangedForTesting(
     const blink::WebBatteryStatus& status) {
   if (!g_test_battery_status_listener)
     return;
   g_test_battery_status_listener->updateBatteryStatus(status);
 }
 
 }  // namespace content