Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 690653003: Fix button state for dragged browser action buttons (Closed)

Created:
6 years, 1 month ago by Devlin
Modified:
6 years, 1 month ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix button state for dragged browser action buttons Dragging a browser action off the toolbar results in the button staying in "pressed" state. Fix it so that it returns to normal state. BUG=428287 Committed: https://crrev.com/73b68e194fad6aa952f85b511c3e9a2b094064f5 Cr-Commit-Position: refs/heads/master@{#301962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/views/toolbar/browser_action_view.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Devlin
Peter, please take a quick look.
6 years, 1 month ago (2014-10-29 20:29:08 UTC) #2
Peter Kasting
LGTM
6 years, 1 month ago (2014-10-29 20:31:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690653003/1
6 years, 1 month ago (2014-10-29 21:27:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-29 22:59:22 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 23:00:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73b68e194fad6aa952f85b511c3e9a2b094064f5
Cr-Commit-Position: refs/heads/master@{#301962}

Powered by Google App Engine
This is Rietveld 408576698