chrome/browser/chromeos/policy/server_backed_device_state.h - Issue 690643002: Add RESTORE_MODE_DISABLED to RestoreMode

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/chromeos/policy/server_backed_device_state.h

Issue 690643002: Add RESTORE_MODE_DISABLED to RestoreMode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/chromeos/login/screens/device_disabled_screen.cc ('K') | « chrome/browser/chromeos/policy/auto_enrollment_client_unittest.cc ('k') | chrome/browser/chromeos/policy/server_backed_device_state.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_CHROMEOS_POLICY_SERVER_BACKED_DEVICE_STATE_H_	5 #ifndef CHROME_BROWSER_CHROMEOS_POLICY_SERVER_BACKED_DEVICE_STATE_H_

6 #define CHROME_BROWSER_CHROMEOS_POLICY_SERVER_BACKED_DEVICE_STATE_H_	6 #define CHROME_BROWSER_CHROMEOS_POLICY_SERVER_BACKED_DEVICE_STATE_H_

7	7

8 namespace policy {	8 namespace policy {

9	9

10 // Dictionary key constants for prefs::kServerBackedDeviceState.	10 // Dictionary key constants for prefs::kServerBackedDeviceState.

11 extern const char kDeviceStateManagementDomain[];	11 extern const char kDeviceStateManagementDomain[];

12 extern const char kDeviceStateRestoreMode[];	12 extern const char kDeviceStateRestoreMode[];

13 extern const char kDeviceStateDisabled[];

14 extern const char kDeviceStateDisabledMessage[];	13 extern const char kDeviceStateDisabledMessage[];

15	14

16 // Values for kDeviceStateRestoreMode.	15 // Values for kDeviceStateRestoreMode.

17 extern const char kDeviceStateRestoreModeReEnrollmentEnforced[];	16 extern const char kDeviceStateRestoreModeReEnrollmentEnforced[];

18 extern const char kDeviceStateRestoreModeReEnrollmentRequested[];	17 extern const char kDeviceStateRestoreModeReEnrollmentRequested[];

	18 extern const char kDeviceStateRestoreModeDisabled[];
	Mattias Nissler (ping if slow) 2014/10/29 17:41:35 Are we positive behavior will be identical for bot Are we positive behavior will be identical for both lost and stolen cases? If not, we might introduce two different identifiers here. On the other hand, I guess we can always deprecated disabled and add finer-grained identifiers when needed later. bartfab (slow) 2014/10/30 14:10:32 Yes, we are positive on that. The UI designers are Show quoted text On 2014/10/29 17:41:35, Mattias Nissler wrote: > Are we positive behavior will be identical for both lost and stolen cases? If > not, we might introduce two different identifiers here. > > On the other hand, I guess we can always deprecated disabled and add > finer-grained identifiers when needed later. Yes, we are positive on that. The UI designers are worried that "lock session" and "lock device" are confusing already. If we were to add "lock stolen device" vs. "lock lost device", peoples' heads would explode.
19	19

20 } // namespace policy	20 } // namespace policy

21	21

22 #endif // CHROME_BROWSER_CHROMEOS_POLICY_SERVER_BACKED_DEVICE_STATE_H_	22 #endif // CHROME_BROWSER_CHROMEOS_POLICY_SERVER_BACKED_DEVICE_STATE_H_

OLD	NEW