Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 690613005: Add a few missing overrides found by a new clang warning. (Closed)

Created:
6 years, 1 month ago by Nico
Modified:
6 years, 1 month ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a few missing overrides found by a new clang warning. Namely, -Winconsistent-missing-override. While here, also remove "virtual" from the functions I'm marking override, like our new override style dictates. No behavior change. BUG=428099, 417463 Committed: https://crrev.com/ef3e4e6cff826927f51cfc74c6d84196e663dfeb Cr-Commit-Position: refs/heads/master@{#302018}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -92 lines) Patch
M pdf/instance.h View 1 chunk +48 lines, -48 lines 0 comments Download
M pdf/out_of_process_instance.h View 1 chunk +44 lines, -44 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
6 years, 1 month ago (2014-10-30 01:14:19 UTC) #2
Lei Zhang
lgtm
6 years, 1 month ago (2014-10-30 01:24:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690613005/1
6 years, 1 month ago (2014-10-30 01:26:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 02:10:13 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 02:10:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef3e4e6cff826927f51cfc74c6d84196e663dfeb
Cr-Commit-Position: refs/heads/master@{#302018}

Powered by Google App Engine
This is Rietveld 408576698