Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 690613004: Remove a couple of stale BUILD.gn files in build/secondary. (Closed)

Created:
6 years, 1 month ago by Dirk Pranke
Modified:
6 years, 1 month ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove a couple of stale BUILD.gn files in build/secondary. There are now files in the primary locations for flac and trace-viewer. R=brettw@chromium.org BUG= Committed: https://crrev.com/e825878113bab9d4d993ce5f5440fb2caf942247 Cr-Commit-Position: refs/heads/master@{#302157}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -396 lines) Patch
D build/secondary/third_party/flac/BUILD.gn View 1 chunk +0 lines, -76 lines 0 comments Download
D build/secondary/third_party/trace-viewer/BUILD.gn View 1 chunk +0 lines, -320 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Dirk Pranke
6 years, 1 month ago (2014-10-29 23:00:01 UTC) #1
brettw
lgtm
6 years, 1 month ago (2014-10-30 00:36:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690613004/1
6 years, 1 month ago (2014-10-30 20:32:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 21:13:50 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 21:14:54 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e825878113bab9d4d993ce5f5440fb2caf942247
Cr-Commit-Position: refs/heads/master@{#302157}

Powered by Google App Engine
This is Rietveld 408576698