Adding Unit Test Coverage for Select Action Bar Cut, Paste, Select All options

content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java

Index: content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java b/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java
index f0044ff970828056ace1bfe3f34a66a2dfeaf0ca..7db83689fd61612027626464997fc0f0507e746b 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java
@@ -31,10 +31,9 @@ public class ContentViewCoreSelectionTest extends ContentShellTestBase {
             + "<input id=\"empty_input_text\" type=\"text\" />"
             + "<br/><p><span id=\"plain_text_1\">SamplePlainTextOne</span></p>"
             + "<br/><p><span id=\"plain_text_2\">SamplePlainTextTwo</span></p>"
-            + "<br/><input id=\"empty_input_text\" type=\"text\" />"
             + "<br/><input id=\"input_text\" type=\"text\" value=\"SampleInputText\" />"
             + "<br/><textarea id=\"empty_textarea\" rows=\"2\" cols=\"20\"></textarea>"
-            + "<br/><textarea id=\"textarea\" rows=\"2\" cols=\"20\">Sample Text</textarea>"
+            + "<br/><textarea id=\"textarea\" rows=\"2\" cols=\"20\">SampleTextArea</textarea>"
             + "<br/><input id=\"readonly_text\" type=\"text\" readonly value=\"Sample Text\"/>"
             + "<br/><input id=\"disabled_text\" type=\"text\" disabled value=\"Sample Text\" />"
             + "<br/><input id=\"input_password\" type=\"password\" value=\"SamplePassword\" />"
@@ -237,6 +236,17 @@ public class ContentViewCoreSelectionTest extends ContentShellTestBase {
 
     @SmallTest
     @Feature({"TextInput"})
+    public void testActionBarConfiguredCorrectlyForTextArea() throws Throwable {
+        DOMUtils.longPressNode(this, mContentViewCore, "textarea");
+        assertWaitForSelectActionBarVisible(true);
+        assertTrue(mContentViewCore.hasSelection());
+        assertNotNull(mContentViewCore.getSelectActionHandler());
+        assertTrue(mContentViewCore.getSelectActionHandler().isSelectionEditable());
+        assertFalse(mContentViewCore.getSelectActionHandler().isSelectionPassword());
+    }
+
+    @SmallTest
+    @Feature({"TextInput"})
     public void testSelectActionBarPlainTextCopy() throws Exception {
         DOMUtils.longPressNode(this, mContentViewCore, "plain_text_1");
         assertWaitForSelectActionBarVisible(true);
@@ -276,6 +286,223 @@ public class ContentViewCoreSelectionTest extends ContentShellTestBase {
         assertClipboardContents(mContentViewCore.getContext(), "SamplePlainTextOne");
     }
 
+    @SmallTest
+    @Feature({"TextInput"})
+    public void testSelectActionBarTextAreaCopy() throws Exception {
+        DOMUtils.longPressNode(this, mContentViewCore, "textarea");
+        assertWaitForSelectActionBarVisible(true);
+        assertTrue(mContentViewCore.hasSelection());
+        assertNotNull(mContentViewCore.getSelectActionHandler());
+        selectActionBarCopy();
+        assertClipboardContents(mContentViewCore.getContext(), "SampleTextArea");
+    }
+
+    @SmallTest
+    @Feature({"TextSelection"})
+    public void testSelectActionBarPlainTextCut() throws Exception {
+        copyStringToClipboard();
+        DOMUtils.longPressNode(this, mContentViewCore, "plain_text_1");
+        assertWaitForSelectActionBarVisible(true);
+        assertTrue(mContentViewCore.hasSelection());
+        assertEquals(mContentViewCore.getSelectedText(), "SamplePlainTextOne");
+        assertNotNull(mContentViewCore.getSelectActionHandler());
+        selectActionBarCut();
+        assertWaitForSelectActionBarVisible(true);
+        assertTrue(mContentViewCore.hasSelection());
+        // Cut option won't be available for plain text.
+        // Hence validating previous Clipboard content.
+        assertClipboardContents(mContentViewCore.getContext(), "SampleTextToCopy");
+    }
+
+    @SmallTest
+    @Feature({"TextInput"})
+    public void testSelectActionBarInputCut() throws Exception {
+        DOMUtils.longPressNode(this, mContentViewCore, "input_text");
+        assertWaitForSelectActionBarVisible(true);
+        assertTrue(mContentViewCore.hasSelection());
+        assertEquals(mContentViewCore.getSelectedText(), "SampleInputText");
+        assertNotNull(mContentViewCore.getSelectActionHandler());
+        selectActionBarCut();
+        assertWaitForSelectActionBarVisible(false);
+        assertFalse(mContentViewCore.hasSelection());
+        assertClipboardContents(mContentViewCore.getContext(), "SampleInputText");
+        assertEquals(mContentViewCore.getSelectedText(), "");
+    }
+
+    @SmallTest
+    @Feature({"TextInput"})
+    public void testSelectActionBarPasswordCut() throws Exception {
+        copyStringToClipboard();
+        DOMUtils.longPressNode(this, mContentViewCore, "input_password");
+        assertWaitForSelectActionBarVisible(true);
+        assertTrue(mContentViewCore.hasSelection());
+        assertNotNull(mContentViewCore.getSelectActionHandler());
+        selectActionBarCut();
+        assertWaitForSelectActionBarVisible(true);
+        assertTrue(mContentViewCore.hasSelection());
+        // Cut option won't be there for Password, hence no change in Clipboard
+        // Validating with previous Clipboard content
+        assertClipboardContents(mContentViewCore.getContext(), "SampleTextToCopy");
+    }
+
+    @SmallTest
+    @Feature({"TextInput"})
+    public void testSelectActionBarTextAreaCut() throws Exception {
+        DOMUtils.longPressNode(this, mContentViewCore, "textarea");
+        assertWaitForSelectActionBarVisible(true);
+        assertTrue(mContentViewCore.hasSelection());
+        assertEquals(mContentViewCore.getSelectedText(), "SampleTextArea");
+        assertNotNull(mContentViewCore.getSelectActionHandler());
+        selectActionBarCut();
+        assertWaitForSelectActionBarVisible(false);
+        assertFalse(mContentViewCore.hasSelection());
+        assertClipboardContents(mContentViewCore.getContext(), "SampleTextArea");
+        assertEquals(mContentViewCore.getSelectedText(), "");
+    }
+
+    @SmallTest
+    @Feature({"TextSelection"})
+    public void testSelectActionBarPlainTextSelectAll() throws Exception {
+        DOMUtils.longPressNode(this, mContentViewCore, "plain_text_1");
+        assertWaitForSelectActionBarVisible(true);
+        assertTrue(mContentViewCore.hasSelection());
+        assertNotNull(mContentViewCore.getSelectActionHandler());
+        selectActionBarSelectAll();
+        assertTrue(mContentViewCore.hasSelection());
+        assertWaitForSelectActionBarVisible(true);
+    }
+
+    @SmallTest
+    @Feature({"TextInput"})
+    public void testSelectActionBarInputSelectAll() throws Exception {
+        DOMUtils.longPressNode(this, mContentViewCore, "input_text");
+        assertWaitForSelectActionBarVisible(true);
+        assertTrue(mContentViewCore.hasSelection());
+        assertNotNull(mContentViewCore.getSelectActionHandler());
+        selectActionBarSelectAll();
+        assertTrue(mContentViewCore.hasSelection());
+        assertWaitForSelectActionBarVisible(true);
+        assertEquals(mContentViewCore.getSelectedText(), "SampleInputText");
+    }
+
+    @SmallTest
+    @Feature({"TextInput"})
+    public void testSelectActionBarPasswordSelectAll() throws Exception {
+        DOMUtils.longPressNode(this, mContentViewCore, "input_password");
+        assertWaitForSelectActionBarVisible(true);
+        assertTrue(mContentViewCore.hasSelection());
+        assertNotNull(mContentViewCore.getSelectActionHandler());
+        selectActionBarSelectAll();
+        assertTrue(mContentViewCore.hasSelection());
+        assertWaitForSelectActionBarVisible(true);

[jdduke (slow), 2014/10/31 17:39:41]

Don't you also want to assert that getSelectedText() is empty, i.e., the
password shouldn't be passed to content/?

[AKVT, 2014/10/31 17:52:09]

Actually selected text we can't validate positively. Due to character issue.
junit.framework.ComparisonFailure: expected:<[••••••••••••••]> but
was:<[**************]>
But we can make negative check
as assertNotSame(mContentViewCore.getSelectedText(), "SamplePassword"); Please
share your opinion

[jdduke (slow), 2014/10/31 17:57:06]

Hmm, nah this is OK.

+    }
+
+    @SmallTest
+    @Feature({"TextInput"})
+    public void testSelectActionBarTextAreaSelectAll() throws Exception {
+        DOMUtils.longPressNode(this, mContentViewCore, "textarea");
+        assertWaitForSelectActionBarVisible(true);
+        assertTrue(mContentViewCore.hasSelection());
+        assertNotNull(mContentViewCore.getSelectActionHandler());
+        selectActionBarSelectAll();
+        assertTrue(mContentViewCore.hasSelection());
+        assertWaitForSelectActionBarVisible(true);
+        assertEquals(mContentViewCore.getSelectedText(), "SampleTextArea");
+    }
+
+    @SmallTest
+    @Feature({"TextSelection"})
+    public void testSelectActionBarPlainTextPaste() throws Exception {
+        copyStringToClipboard();
+        DOMUtils.longPressNode(this, mContentViewCore, "plain_text_1");
+        assertWaitForSelectActionBarVisible(true);
+        assertTrue(mContentViewCore.hasSelection());
+        assertNotNull(mContentViewCore.getSelectActionHandler());
+        selectActionBarPaste();
+        DOMUtils.longPressNode(this, mContentViewCore, "plain_text_1");
+        assertWaitForSelectActionBarVisible(true);
+        assertTrue(mContentViewCore.hasSelection());
+        // Paste option won't be available for plain text.
+        // Hence content won't be changed.
+        assertNotSame(mContentViewCore.getSelectedText(), "SampleTextToCopy");
+    }
+
+    @SmallTest
+    @Feature({"TextInput"})
+    public void testSelectActionBarInputPaste() throws Exception {
+        copyStringToClipboard();
+        DOMUtils.longPressNode(this, mContentViewCore, "input_text");
+        assertWaitForSelectActionBarVisible(true);
+        assertTrue(mContentViewCore.hasSelection());
+        assertNotNull(mContentViewCore.getSelectActionHandler());
+        selectActionBarPaste();
+        DOMUtils.clickNode(this, mContentViewCore, "plain_text_1");
+        DOMUtils.longPressNode(this, mContentViewCore, "input_text");
+        assertWaitForSelectActionBarVisible(true);
+        assertTrue(mContentViewCore.hasSelection());
+        assertEquals(mContentViewCore.getSelectedText(), "SampleTextToCopy");
+    }
+
+    @SmallTest
+    @Feature({"TextInput"})
+    public void testSelectActionBarPasswordPaste() throws Exception {
+        copyStringToClipboard();
+        DOMUtils.longPressNode(this, mContentViewCore, "input_password");
+        assertWaitForSelectActionBarVisible(true);
+        assertTrue(mContentViewCore.hasSelection());
+        assertNotNull(mContentViewCore.getSelectActionHandler());
+        selectActionBarPaste();
+        // Paste option won't be there for Password, hence no action happens

[jdduke (slow), 2014/10/31 17:39:41]

This comment is misleading (as are several others). Yes, the paste option isn't
there, but you're skipping that check by calling paste() directly.

[AKVT, 2014/10/31 17:52:09]

My intention is even if we call paste, expected action won't be happening.
Please suggest any other way we can cover this scenario.

+        DOMUtils.clickNode(this, mContentViewCore, "plain_text_1");
+        DOMUtils.longPressNode(this, mContentViewCore, "input_password");
+        assertWaitForSelectActionBarVisible(true);
+        assertTrue(mContentViewCore.hasSelection());
+        assertNotSame(mContentViewCore.getSelectedText(), "SampleTextToCopy");
+    }
+
+    @SmallTest
+    @Feature({"TextInput"})
+    public void testSelectActionBarTextAreaPaste() throws Exception {
+        copyStringToClipboard();
+        DOMUtils.longPressNode(this, mContentViewCore, "textarea");
+        assertWaitForSelectActionBarVisible(true);
+        assertTrue(mContentViewCore.hasSelection());
+        assertNotNull(mContentViewCore.getSelectActionHandler());
+        selectActionBarPaste();
+        DOMUtils.clickNode(this, mContentViewCore, "plain_text_1");
+        DOMUtils.longPressNode(this, mContentViewCore, "textarea");
+        assertWaitForSelectActionBarVisible(true);
+        assertTrue(mContentViewCore.hasSelection());
+        assertEquals(mContentViewCore.getSelectedText(), "SampleTextToCopy");
+    }
+
+    private void selectActionBarPaste() {
+        ThreadUtils.runOnUiThreadBlocking(new Runnable() {
+            @Override
+            public void run() {
+                mContentViewCore.getSelectActionHandler().paste();
+            }
+        });
+    }
+
+    private void selectActionBarSelectAll() {
+        ThreadUtils.runOnUiThreadBlocking(new Runnable() {
+            @Override
+            public void run() {
+                mContentViewCore.getSelectActionHandler().selectAll();
+            }
+        });
+    }
+
+    private void selectActionBarCut() {
+        ThreadUtils.runOnUiThreadBlocking(new Runnable() {
+            @Override
+            public void run() {
+                mContentViewCore.getSelectActionHandler().cut();

[jdduke (slow), 2014/10/31 17:39:41]

The biggest problem I have with these tests is that we have extra dismissal
logic in SelectActionModeCallback.java that's being entirely skipped here. I'm
not sure if there's an easy way to fully test that though...

[AKVT, 2014/10/31 17:52:09]

IMO, even though we have a SelectActionModeCallback, we are not using its
functionality here, we just use Handler functionalilties. As I discussed in
previous patch, we need to have separate coverage for SelectActionModeCallback
using Menus. and directly call menu clicks without relying handler calls. In
that case we can cover the dismissal scenarios.
Please share your thoughts on  this.

+            }
+        });
+    }
+
     private void selectActionBarCopy() {
         ThreadUtils.runOnUiThreadBlocking(new Runnable() {
             @Override
@@ -357,7 +584,7 @@ public class ContentViewCoreSelectionTest extends ContentShellTestBase {
         ClipboardManager clipboardManager =
                 (ClipboardManager) getActivity().getSystemService(
                         Context.CLIPBOARD_SERVICE);
-        ClipData clip = ClipData.newPlainText("test", "Text to copy");
+        ClipData clip = ClipData.newPlainText("test", "SampleTextToCopy");
         clipboardManager.setPrimaryClip(clip);
     }