Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 690603003: Reset animation player map on disconnecting Inspector frontend. (Closed)

Created:
6 years, 1 month ago by sof
Modified:
6 years, 1 month ago
CC:
blink-reviews, shans, apavlov+blink_chromium.org, rjwright, Steve Block, caseq+blink_chromium.org, aandrey+blink_chromium.org, pfeldman+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, dstockwell, Timothy Loh, devtools-reviews_chromium.org, Eric Willigers, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, blink-reviews-animation_chromium.org, vsevik+blink_chromium.org, Mike Lawther (Google), sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Reset animation player map on disconnecting Inspector frontend. Clear out the node ID to AnimationPlayer map on disconnect to avoid references to elements (and their documents) from lingering longer than necessary. R=haraken,aandrey BUG=428685 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184743

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/core/inspector/InspectorAnimationAgent.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sof
Please take a look.
6 years, 1 month ago (2014-10-31 11:05:48 UTC) #2
haraken
LGTM
6 years, 1 month ago (2014-10-31 11:08:54 UTC) #3
aandrey
lgtm
6 years, 1 month ago (2014-10-31 11:39:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690603003/1
6 years, 1 month ago (2014-10-31 12:35:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/34593)
6 years, 1 month ago (2014-10-31 14:25:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690603003/1
6 years, 1 month ago (2014-10-31 14:26:44 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 16:16:36 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184743

Powered by Google App Engine
This is Rietveld 408576698