Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 690593002: Remove deprecated updateBackingStoreAndCheckValidity from WebAXObject (Closed)

Created:
6 years, 1 month ago by kkristof
Modified:
6 years, 1 month ago
Reviewers:
haraken, dmazzoni, Mike West
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove deprecated updateBackingStoreAndCheckValidity from WebAXObject This function isn't used anymore. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185610

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M Source/web/WebAXObject.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebAXObject.h View 1 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
kkristof
After this https://codereview.chromium.org/684093003/ is accepted we could remove updateBackingStoreAndCheckValidity from WebAXObject
6 years, 1 month ago (2014-10-29 10:21:37 UTC) #3
kkristof
After this https://codereview.chromium.org/684093003/ is accepted we could remove updateBackingStoreAndCheckValidity from WebAXObject
6 years, 1 month ago (2014-10-29 10:21:38 UTC) #4
haraken
LGTM
6 years, 1 month ago (2014-10-29 11:17:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690593002/1
6 years, 1 month ago (2014-10-30 07:36:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/18695)
6 years, 1 month ago (2014-10-30 07:44:24 UTC) #9
dmazzoni
+dglazkov for public/web
6 years, 1 month ago (2014-10-30 15:11:43 UTC) #11
kkristof
I have rebased the patch set to the current master.
6 years, 1 month ago (2014-11-17 14:45:07 UTC) #13
dmazzoni
+mkwst for public/web
6 years, 1 month ago (2014-11-17 16:18:51 UTC) #15
Mike West
LGTM.
6 years, 1 month ago (2014-11-19 07:37:17 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690593002/20001
6 years, 1 month ago (2014-11-19 16:38:18 UTC) #18
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 17:44:50 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185610

Powered by Google App Engine
This is Rietveld 408576698