Chromium Code Reviews

Issue 690583002: Add PDF viewer example. (Closed)

Created:
6 years, 1 month ago by jam
Modified:
6 years, 1 month ago
Reviewers:
Ben Goodger (Google)
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 : #

Patch Set 2 : mousewheel too #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Stats (+110 lines, -86 lines)
M DEPS View 3 chunks +8 lines, -0 lines 0 comments
M examples/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments
M examples/bitmap_uploader/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments
A + examples/pdf_viewer/BUILD.gn View 1 chunk +3 lines, -5 lines 0 comments
A + examples/pdf_viewer/DEPS View 1 chunk +1 line, -1 line 0 comments
A + examples/pdf_viewer/pdf_viewer.cc View 9 chunks +95 lines, -79 lines 0 comments
M examples/png_viewer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments
M mojo/shell/context.cc View 1 chunk +1 line, -0 lines 0 comments

Messages

Total messages: 5 (2 generated)
jam
6 years, 1 month ago (2014-10-29 16:24:13 UTC) #3
Ben Goodger (Google)
awesome! lgtm
6 years, 1 month ago (2014-10-29 17:03:32 UTC) #4
jam
6 years, 1 month ago (2014-10-29 18:00:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:60001) manually as
7cd059b837eb714f7cf32e9a871809ac26569b22 (presubmit successful).

Powered by Google App Engine