android_webview/native/aw_contents.h - Issue 690553002: aw: Destroy ContentViewCore and WebContents together

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_contents.h

Issue 690553002: aw: Destroy ContentViewCore and WebContents together (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use Handler Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/java/src/org/chromium/android_webview/AwContents.java ('K') | « android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java ('k') | android_webview/native/aw_contents.cc » ('j') | android_webview/native/aw_contents.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/native/aw_contents.h

diff --git a/android_webview/native/aw_contents.h b/android_webview/native/aw_contents.h

index 8f42a9202cbeeab097ed3e80a2d4c3be3cfed6a7..1b1b18070312a5a684db04bccbe4d02243436470 100644

--- a/android_webview/native/aw_contents.h

+++ b/android_webview/native/aw_contents.h

@@ -232,9 +232,9 @@ class AwContents : public FindHelper::Listener,

void HideGeolocationPrompt(const GURL& origin);

JavaObjectWeakGlobalRef java_ref_;

- scoped_ptr<content::WebContents> web_contents_;

scoped_ptr<AwWebContentsDelegate> web_contents_delegate_;

scoped_ptr<AwContentsClientBridge> contents_client_bridge_;

+ scoped_ptr<content::WebContents> web_contents_;

hush (inactive) 2014/10/31 20:58:16 what's the purpose of this move?

boliu 2014/10/31 21:47:05 This is the "Reordered some native AwContents memb

scoped_ptr<AwRenderViewHostExt> render_view_host_ext_;

scoped_ptr<FindHelper> find_helper_;

scoped_ptr<IconHelper> icon_helper_;