Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java

Issue 690553002: aw: Destroy ContentViewCore and WebContents together (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test to ShouldOverrideUrlLoading Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
index 43cbe9286f5a97e1f525bf5b3bb36bc40c10e8dc..73ba3be4be3f4e94cc478ba5d19aacb04036a880 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
@@ -103,10 +103,6 @@ public class AwContentsTest extends AwTestBase {
createAwTestContainerView(mContentsClient).getAwContents();
awContents.destroy();
- assertNull(awContents.getWebContents());
- assertNull(awContents.getContentViewCore());
- assertNull(awContents.getNavigationController());
-
// The documentation for WebView#destroy() reads "This method should be called
// after this WebView has been removed from the view system. No other methods
// may be called on this WebView after destroy".
@@ -342,8 +338,8 @@ public class AwContentsTest extends AwTestBase {
pollOnUiThread(new Callable<Boolean>() {
@Override
public Boolean call() {
- return awContents.getFavicon() != null &&
- !awContents.getFavicon().sameAs(defaultFavicon);
+ return awContents.getFavicon() != null
+ && !awContents.getFavicon().sameAs(defaultFavicon);
}
});

Powered by Google App Engine
This is Rietveld 408576698