android_webview/browser/aw_contents_client_bridge_base.cc - Issue 690553002: aw: Destroy ContentViewCore and WebContents together

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_contents_client_bridge_base.cc

Issue 690553002: aw: Destroy ContentViewCore and WebContents together (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: test to ShouldOverrideUrlLoading Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/browser/aw_contents_client_bridge_base.h ('k') | android_webview/java/src/org/chromium/android_webview/AwContents.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/browser/aw_contents_client_bridge_base.cc

diff --git a/android_webview/browser/aw_contents_client_bridge_base.cc b/android_webview/browser/aw_contents_client_bridge_base.cc

index 13f9e5f6e88bd40574acec6a95328a19ff498afb..5dff7a7cf7f677dbf8c306ba44721a1e8d806223 100644

--- a/android_webview/browser/aw_contents_client_bridge_base.cc

+++ b/android_webview/browser/aw_contents_client_bridge_base.cc

@@ -47,11 +47,6 @@ void AwContentsClientBridgeBase::Associate(

new UserData(handler));

}

-void AwContentsClientBridgeBase::Disassociate(

- WebContents* web_contents) {

- web_contents->RemoveUserData(kAwContentsClientBridgeBase);

// static

AwContentsClientBridgeBase* AwContentsClientBridgeBase::FromWebContents(

WebContents* web_contents) {