Issue 6905127: Make newspace semispaces be single page-sized memory chunks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6905127: Make newspace semispaces be single page-sized memory chunks. (Closed)

Created:
9 years, 7 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/gc

Visibility:
Public.

Description

Make newspace semispaces be single page-sized memory chunks. In anticipation of making them multi-paged. Committed: http://code.google.com/p/v8/source/detail?r=7736

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change FIXME to TODO #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -9 lines)			Patch
M	src/heap.cc	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	src/spaces.h	View	1	6 chunks	+46 lines, -5 lines	0 comments	Download
M	src/spaces.cc	View	1	8 chunks	+27 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

9 years, 7 months ago (2011-05-02 06:43:01 UTC) #2

LGTM if it lints.

http://codereview.chromium.org/6905127/diff/1/src/spaces.h
File src/spaces.h (right):

http://codereview.chromium.org/6905127/diff/1/src/spaces.h#newcode1485
src/spaces.h:1485: // FIXME: Change when there is more than one page.
All these FIXMEs need to be 'TODO(gc):' instead.

Expand Messages | Collapse Messages