Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: chrome/browser/ui/website_settings/website_settings.h

Issue 690483003: Log major user interactions with the WebsiteSettings (origin info) bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix indentation in switch clause. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/website_settings.h
diff --git a/chrome/browser/ui/website_settings/website_settings.h b/chrome/browser/ui/website_settings/website_settings.h
index 1c8e42b376e059d5d8ee8ff39bed3bc625499399..a167c255d2094af47d1b38b5b0ec0140f5723822 100644
--- a/chrome/browser/ui/website_settings/website_settings.h
+++ b/chrome/browser/ui/website_settings/website_settings.h
@@ -71,6 +71,21 @@ class WebsiteSettings : public TabSpecificContentSettings::SiteDataObserver {
SITE_IDENTITY_STATUS_DEPRECATED_SIGNATURE_ALGORITHM,
};
+ // UMA statistics for WebsiteSettings. Do not reorder or remove existing
+ // fields.
+ enum WebsiteSettingsAction {
+ WEBSITE_SETTINGS_OPENED = 0,
+ WEBSITE_SETTINGS_PERMISSIONS_TAB_SELECTED,
+ WEBSITE_SETTINGS_CONNECTION_TAB_SELECTED,
+ WEBSITE_SETTINGS_CONNECTION_TAB_SHOWN_IMMEDIATELY,
+ WEBSITE_SETTINGS_COOKIES_DIALOG_OPENED,
+ WEBSITE_SETTINGS_CHANGED_PERMISSION,
+ WEBSITE_SETTINGS_CERTIFICATE_DIALOG_OPENED,
+ WEBSITE_SETTINGS_TRANSPARENCY_VIEWER_OPENED,
+ WEBSITE_SETTINGS_CONNECTION_HELP_OPENED,
+ WEBSITE_SETTINGS_COUNT
+ };
+
// Creates a WebsiteSettings for the passed |url| using the given |ssl| status
// object to determine the status of the site's connection. The
// |WebsiteSettings| takes ownership of the |ui|.
@@ -83,6 +98,8 @@ class WebsiteSettings : public TabSpecificContentSettings::SiteDataObserver {
content::CertStore* cert_store);
~WebsiteSettings() override;
+ void RecordWebsiteSettingsAction(WebsiteSettingsAction action);
+
// This method is called when ever a permission setting is changed.
void OnSitePermissionChanged(ContentSettingsType type,
ContentSetting value);

Powered by Google App Engine
This is Rietveld 408576698