Log major user interactions with the WebsiteSettings (origin info) bubble.

chrome/browser/ui/website_settings/website_settings.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/website_settings/website_settings.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 184 matching lines @@
         &visit_count_task_tracker_);
   }
 
   PresentSitePermissions();
   PresentSiteData();
   PresentSiteIdentity();
   PresentHistoryInfo(base::Time());
 
   // Every time the Website Settings UI is opened a |WebsiteSettings| object is
   // created. So this counts how ofter the Website Settings UI is opened.
-  content::RecordAction(base::UserMetricsAction("WebsiteSettings_Opened"));
+  RecordWebsiteSettingsAction(WEBSITE_SETTINGS_OPENED);
 }
 
 WebsiteSettings::~WebsiteSettings() {
 }
 
+void WebsiteSettings::RecordWebsiteSettingsAction(
+    WebsiteSettingsAction action) {
+  UMA_HISTOGRAM_ENUMERATION("WebsiteSettings",

[Ilya Sherman, 2014/10/29 23:55:42]

Also, is "WebsiteSettings" a namespace that's already in use?  If not, might
there be an existing namespace that you could use, rather than defining a new
one?

[Ilya Sherman, 2014/10/29 23:55:42]

This histogram currently just has a namespace, but is itself unnamed.  It's like
writing "namespace website_settings { class { ... }; }".  Please give the
histogram a name as well as a namespace :)

[lgarron, 2014/10/30 00:10:19]

I originally planned just to have this histogram (in the top-level namespace) to
keep it simple, and then added the other. I suppose I could name this
WebsiteSettings.Actions.

(This is why I remarked that the namespacing for Actions was easier. ;-)

[lgarron, 2014/10/30 00:10:19]

It's used by WebsiteSettings.PermissionChanged (unowned, maybe I should take
ownership). In addition, this histogram is going to supersede two actions:

- WebsiteSettings_Opened
- WebsiteSettings_CookiesDialogOpened

[lgarron, 2014/10/31 00:50:48]

Acknowledged.

+                            action,
+                            WEBSITE_SETTINGS_COUNT);
+
+  // Use a separate histogram to record actions if they are done on a page with
+  // an HTTPS URL. Note that this *disregards* security status.
+  if (site_url_.SchemeIs(url::kHttpsScheme)) {
+    UMA_HISTOGRAM_ENUMERATION("WebsiteSettings.HTTPS_URL",

[Ilya Sherman, 2014/10/29 23:55:42]

Optional nit: I'd write "HTTPS_URL" as "SecureUrl" or "HttpsUrl" or something
like that.

[lgarron, 2014/10/31 00:50:48]

SecureURL is probably a bad idea, but HttpsUrl sounds find, even if it's ugly.
Are you fine with having the following two histograms?

WebsiteSettings.Action
WebsiteSettings.Action.HttpsUrl

+                              action,
+                              WEBSITE_SETTINGS_COUNT);
+  }
+}
+
+
 void WebsiteSettings::OnSitePermissionChanged(ContentSettingsType type,
                                               ContentSetting setting) {
   // Count how often a permission for a specific content type is changed using
   // the Website Settings UI.
   UMA_HISTOGRAM_COUNTS("WebsiteSettings.PermissionChanged", type);
 
+  // This is technically redundant given the histogram above, but putting the
+  // total count of permission changes in another histogram makes it easier to
+  // compare it against other kinds of actions in WebsiteSettings[PopupView].
+  RecordWebsiteSettingsAction(WEBSITE_SETTINGS_CHANGED_PERMISSION);
+
   ContentSettingsPattern primary_pattern;
   ContentSettingsPattern secondary_pattern;
   switch (type) {
     case CONTENT_SETTINGS_TYPE_GEOLOCATION:
     case CONTENT_SETTINGS_TYPE_MIDI_SYSEX:
       // TODO(markusheintz): The rule we create here should also change the
       // location permission for iframed content.
       primary_pattern = ContentSettingsPattern::FromURLNoWildcard(site_url_);
       secondary_pattern = ContentSettingsPattern::FromURLNoWildcard(site_url_);
       break;
@@ skipping 393 matching lines @@
   // the user's attention to the issue. If the site does not provide a
   // certificate because it was loaded over an unencrypted connection, don't
   // select the connection tab.
   WebsiteSettingsUI::TabId tab_id = WebsiteSettingsUI::TAB_ID_PERMISSIONS;
   if (site_connection_status_ == SITE_CONNECTION_STATUS_ENCRYPTED_ERROR ||
       site_connection_status_ == SITE_CONNECTION_STATUS_MIXED_CONTENT ||
       site_identity_status_ == SITE_IDENTITY_STATUS_ERROR ||
       site_identity_status_ == SITE_IDENTITY_STATUS_CERT_REVOCATION_UNKNOWN ||
       site_identity_status_ == SITE_IDENTITY_STATUS_ADMIN_PROVIDED_CERT ||
       site_identity_status_ ==
-          SITE_IDENTITY_STATUS_DEPRECATED_SIGNATURE_ALGORITHM)
+          SITE_IDENTITY_STATUS_DEPRECATED_SIGNATURE_ALGORITHM) {
     tab_id = WebsiteSettingsUI::TAB_ID_CONNECTION;
+    RecordWebsiteSettingsAction(
+      WEBSITE_SETTINGS_CONNECTION_TAB_SHOWN_IMMEDIATELY);
+  }
   ui_->SetSelectedTab(tab_id);
 }
 
 void WebsiteSettings::PresentSitePermissions() {
   PermissionInfoList permission_info_list;
 
   WebsiteSettingsUI::PermissionInfo permission_info;
   for (size_t i = 0; i < arraysize(kPermissionType); ++i) {
     permission_info.type = kPermissionType[i];
     if (permission_info.type == CONTENT_SETTINGS_TYPE_MIDI_SYSEX) {
@@ skipping 129 matching lines @@
   if (visited_before_today) {
     first_visit_text = l10n_util::GetStringFUTF16(
         IDS_PAGE_INFO_SECURITY_TAB_VISITED_BEFORE_TODAY,
         base::TimeFormatShortDate(first_visit));
   } else {
     first_visit_text = l10n_util::GetStringUTF16(
         IDS_PAGE_INFO_SECURITY_TAB_FIRST_VISITED_TODAY);
   }
   ui_->SetFirstVisit(first_visit_text);
 }