Log major user interactions with the WebsiteSettings (origin info) bubble.

chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h"
 
 #include <algorithm>
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 372 matching lines @@
                                              const ui::Event& event) {
   if (button == reset_decisions_button_)
     presenter_->OnRevokeSSLErrorBypassButtonPressed();
   GetWidget()->Close();
 }
 
 void WebsiteSettingsPopupView::LinkClicked(views::Link* source,
                                            int event_flags) {
   if (source == cookie_dialog_link_) {
     // Count how often the Collected Cookies dialog is opened.
-    content::RecordAction(
-        base::UserMetricsAction("WebsiteSettings_CookiesDialogOpened"));
+    presenter_->RecordWebsiteSettingsAction(
+        WebsiteSettings::WEBSITE_SETTINGS_COOKIES_DIALOG_OPENED);
     new CollectedCookiesViews(web_contents_);
   } else if (source == certificate_dialog_link_) {
     gfx::NativeWindow parent = GetAnchorView() ?
         GetAnchorView()->GetWidget()->GetNativeWindow() : NULL;
+    presenter_->RecordWebsiteSettingsAction(
+        WebsiteSettings::WEBSITE_SETTINGS_CERTIFICATE_DIALOG_OPENED);
     ShowCertificateViewerByID(web_contents_, parent, cert_id_);
   } else if (source == signed_certificate_timestamps_link_) {
     chrome::ShowSignedCertificateTimestampsViewer(
         web_contents_, signed_certificate_timestamp_ids_);
+    presenter_->RecordWebsiteSettingsAction(
+        WebsiteSettings::WEBSITE_SETTINGS_TRANSPARENCY_VIEWER_OPENED);
   } else if (source == help_center_link_) {
     browser_->OpenURL(
         content::OpenURLParams(GURL(chrome::kPageInfoHelpCenterURL),
                                content::Referrer(),
                                NEW_FOREGROUND_TAB,
                                ui::PAGE_TRANSITION_LINK,
                                false));
+    presenter_->RecordWebsiteSettingsAction(
+        WebsiteSettings::WEBSITE_SETTINGS_CONNECTION_HELP_OPENED);
   }
 }
 
 void WebsiteSettingsPopupView::TabSelectedAt(int index) {
+  switch (index) {
+    case TAB_ID_PERMISSIONS: {
+      presenter_->RecordWebsiteSettingsAction(
+          WebsiteSettings::WEBSITE_SETTINGS_PERMISSIONS_TAB_SELECTED);
+      break;
+    }

[Ilya Sherman, 2014/10/29 23:55:42]

nit: No need for curly braces for case stmts.

[lgarron, 2014/10/31 00:50:47]

Acknowledged.

+    case TAB_ID_CONNECTION: {
+      // If the Connection tab is selected first, we're still inside the
+      // construction of presenter_. In that case, the action is already logged
+      // by WEBSITE_SETTINGS_CONNECTION_TAB_SHOWN_IMMEDIATELY.
+      if (presenter_) {
+        presenter_->RecordWebsiteSettingsAction(
+            WebsiteSettings::WEBSITE_SETTINGS_CONNECTION_TAB_SELECTED);
+      }
+      break;
+    }
+    default: {
+      assert(false);

[Ilya Sherman, 2014/10/29 23:55:42]

nit: Did you mean "NOTREACHED()"?

[lgarron, 2014/10/30 00:10:19]

For this and the braces, I was following the C++ style guide for switch
statements:

http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Loops_and_Swi...

http://www.chromium.org/developers/coding-style doesn't seem to contain anything
to override it.

If everyone's using some other conventions for Chromium, are those documented
anywhere? :-P

[Ilya Sherman, 2014/10/30 01:32:56]

Note that the style guide says "case blocks in switch statements can have curly
braces or not, depending on your preference".  In general, in Chromium code we
omit curly braces for case blocks unless they are necessary for the code to
compile.  (If the local style in this file is different, then feel free to
ignore this comment.)

For assert(false) vs NOTREACHED, Chromium code does not, in general, use
"assert"; we use DCHECK, CHECK, and NOTREACHED.  I'm not sure this is documented
anywhere, but it's not purely a stylistic concern -- DCHECK has slightly
different semantics vs. assert.

[lgarron, 2014/10/31 00:50:47]

Acknowledged.

+    }
+  }
   tabbed_pane_->GetSelectedTab()->Layout();
   SizeToContents();
 }
 
 gfx::Size WebsiteSettingsPopupView::GetPreferredSize() const {
   if (header_ == NULL && tabbed_pane_ == NULL)
     return views::View::GetPreferredSize();
 
   int height = 0;
   if (header_)
@@ skipping 383 matching lines @@
 
   if (reset_decisions_button) {
     content_layout->StartRow(1, 0);
     content_layout->AddView(reset_decisions_button);
   }
 
   layout->AddView(content_pane, 1, 1, views::GridLayout::LEADING,
                   views::GridLayout::LEADING);
   layout->AddPaddingRow(0, kConnectionSectionPaddingBottom);
 }