Issue 690483002: Don't crash when importing a module that doesn't export

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 690483002: Don't crash when importing a module that doesn't export (Closed)

Created:
6 years, 1 month ago by abarth-chromium

Modified:
6 years, 1 month ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, esprehn

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Don't crash when importing a module that doesn't export Instead of crashing, we should use the value "undefined". There's some question as to whether we should default to the document, but we can resolve that later. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dba1780e16f607fe2e7835c2040f1c181a76d142

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -1 line)			Patch
M	sky/engine/bindings/core/v8/ScriptController.cpp	View	1 chunk	+3 lines, -1 line	0 comments	Download
A +	sky/tests/modules/import-without-export.sky	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	sky/tests/modules/import-without-export-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	sky/tests/modules/resources/does-not-export.sky	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

abarth-chromium

6 years, 1 month ago (2014-10-28 21:13:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
dba1780e16f607fe2e7835c2040f1c181a76d142 (presubmit successful).