Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 690473002: Add API tests for the chrome.hid API. (Closed)

Created:
6 years, 1 month ago by Reilly Grant (use Gerrit)
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add API tests for the chrome.hid API. These test validate that the implementation of the chrome.hid API is using the API provided by //device/hid correctly. It does not talk to real devices or validate platform-specific functionality. BUG= Committed: https://crrev.com/e48477cd0a73dce8d17a2a6290434602252d6ba6 Cr-Commit-Position: refs/heads/master@{#302117}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+576 lines, -1 line) Patch
M device/hid/hid_service.h View 1 chunk +2 lines, -0 lines 0 comments Download
M device/hid/hid_service.cc View 2 chunks +8 lines, -1 line 0 comments Download
A extensions/browser/api/hid/hid_apitest.cc View 1 chunk +187 lines, -0 lines 0 comments Download
M extensions/shell/app_shell.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A extensions/test/data/api_test/hid/api/background.js View 1 chunk +363 lines, -0 lines 0 comments Download
A extensions/test/data/api_test/hid/api/manifest.json View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Reilly Grant (use Gerrit)
rockot@, please take a look at these awesome tests!
6 years, 1 month ago (2014-10-29 23:08:24 UTC) #2
Reilly Grant (use Gerrit)
Now that I've actually added you to the reviewers list: rockot@, please take a look ...
6 years, 1 month ago (2014-10-30 14:17:15 UTC) #4
Ken Rockot(use gerrit already)
I agree that these are awesome tests! lgtm
6 years, 1 month ago (2014-10-30 17:20:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690473002/20001
6 years, 1 month ago (2014-10-30 17:42:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years, 1 month ago (2014-10-30 18:42:28 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 18:43:02 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e48477cd0a73dce8d17a2a6290434602252d6ba6
Cr-Commit-Position: refs/heads/master@{#302117}

Powered by Google App Engine
This is Rietveld 408576698