Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 690433004: Add inspect command to skydb (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Add inspect command to skydb This CL adds an "inspect" command to skydb that injects the inspector module into the page and prints some instructions for opening the inspector. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dc4bd37c9de4b9f9e764a23d1147de20bd0fb544

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -11 lines) Patch
M sky/engine/public/web/WebView.h View 1 chunk +3 lines, -0 lines 1 comment Download
M sky/engine/web/WebViewImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 2 chunks +12 lines, -0 lines 1 comment Download
M sky/tools/debugger/debugger.cc View 4 chunks +16 lines, -4 lines 0 comments Download
M sky/tools/debugger/debugger.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M sky/tools/debugger/prompt/prompt.cc View 2 chunks +17 lines, -4 lines 0 comments Download
M sky/viewer/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M sky/viewer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M sky/viewer/document_view.h View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/viewer/document_view.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A + sky/viewer/services/inspector.mojom View 1 chunk +2 lines, -3 lines 0 comments Download
A sky/viewer/services/inspector_impl.h View 1 chunk +35 lines, -0 lines 0 comments Download
A sky/viewer/services/inspector_impl.cc View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
6 years, 1 month ago (2014-10-28 23:41:58 UTC) #1
eseidel
lgtm https://codereview.chromium.org/690433004/diff/1/sky/engine/public/web/WebView.h File sky/engine/public/web/WebView.h (right): https://codereview.chromium.org/690433004/diff/1/sky/engine/public/web/WebView.h#newcode132 sky/engine/public/web/WebView.h:132: virtual void injectModule(const WebString&) = 0; Can this ...
6 years, 1 month ago (2014-10-29 00:05:56 UTC) #2
abarth-chromium
6 years, 1 month ago (2014-10-29 00:08:29 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
dc4bd37c9de4b9f9e764a23d1147de20bd0fb544 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698