Issue 690433002: Fix the inspector and integrate it with skydb

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 690433002: Fix the inspector and integrate it with skydb (Closed)

Created:
6 years, 1 month ago by eseidel

Modified:
6 years, 1 month ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix the inspector and integrate it with skydb R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/27c2b44cc34e6fdf42e864fc139c7e9f12500831

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -10 lines)			Patch
M	sky/framework/inspector/dom-agent.sky	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	sky/tools/sky_server	View	3 chunks	+22 lines, -6 lines	1 comment	Download
M	sky/tools/skydb	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

lgtm https://codereview.chromium.org/690433002/diff/1/sky/tools/sky_server File sky/tools/sky_server (right): https://codereview.chromium.org/690433002/diff/1/sky/tools/sky_server#newcode28 sky/tools/sky_server:28: print os.path.abspath(args.app_path) Spurious?

6 years, 1 month ago (2014-10-28 20:16:43 UTC) #1

eseidel

6 years, 1 month ago (2014-10-28 20:18:22 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
27c2b44cc34e6fdf42e864fc139c7e9f12500831 (presubmit successful).

Expand Messages | Collapse Messages