Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Unified Diff: sdk/lib/_internal/pub/test/build/defaults_to_release_mode_test.dart

Issue 69043003: Allow user to specify mode for pub build/serve. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Get rid of "--minify" flags. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/build/defaults_to_release_mode_test.dart
diff --git a/sdk/lib/_internal/pub/test/transformer/mode_defaults_to_release_in_build_test.dart b/sdk/lib/_internal/pub/test/build/defaults_to_release_mode_test.dart
similarity index 72%
copy from sdk/lib/_internal/pub/test/transformer/mode_defaults_to_release_in_build_test.dart
copy to sdk/lib/_internal/pub/test/build/defaults_to_release_mode_test.dart
index 5109c82e690a19433de1634ce2c2c78c3057e4d4..7d0d4825f4bd8b76263d87f399f0d0d521cbb69e 100644
--- a/sdk/lib/_internal/pub/test/transformer/mode_defaults_to_release_in_build_test.dart
+++ b/sdk/lib/_internal/pub/test/build/defaults_to_release_mode_test.dart
@@ -7,22 +7,22 @@ library pub_tests;
import '../descriptor.dart' as d;
import '../test_pub.dart';
-final transformer = """
+const TRANSFORMER = """
import 'dart:async';
import 'package:barback/barback.dart';
+import 'package:source_maps/source_maps.dart';
class ModeTransformer extends Transformer {
final BarbackSettings settings;
-
ModeTransformer.asPlugin(this.settings);
String get allowedExtensions => '.txt';
Future apply(Transform transform) {
- return transform.primaryInput.readAsString().then((contents) {
- transform.addOutput(
- new Asset.fromString(transform.primaryInput.id, settings.mode.name));
+ return new Future.value().then((_) {
+ var id = transform.primaryInput.id.changeExtension(".out");
+ transform.addOutput(new Asset.fromString(id, settings.mode.toString()));
});
}
}
@@ -30,14 +30,14 @@ class ModeTransformer extends Transformer {
main() {
initConfig();
- integration("mode defaults to 'release' in pub build", () {
+ integration("defaults to release mode", () {
d.dir(appPath, [
d.pubspec({
"name": "myapp",
"transformers": ["myapp/src/transformer"]
}),
d.dir("lib", [d.dir("src", [
- d.file("transformer.dart", transformer)
+ d.file("transformer.dart", TRANSFORMER)
])]),
d.dir("web", [
d.file("foo.txt", "foo")
@@ -47,12 +47,11 @@ main() {
createLockFile('myapp', pkg: ['barback']);
schedulePub(args: ["build"],
- output: new RegExp(r"Built 1 file!"),
exitCode: 0);
d.dir(appPath, [
d.dir('build', [
- d.file('foo.txt', 'release')
+ d.file('foo.out', 'release')
])
]).validate();
});

Powered by Google App Engine
This is Rietveld 408576698