Issue 6904166: Read isolate from page, not through map.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6904166: Read isolate from page, not through map. (Closed)

Created:
9 years, 7 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/gc

Visibility:
Public.

Read isolate from page, not through map. Committed: http://code.google.com/p/v8/source/detail?r=7762

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -47 lines)			Patch
M	src/heap.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/mark-compact.cc	View	1	7 chunks	+7 lines, -7 lines	0 comments	Download
M	src/objects.h	View	1	2 chunks	+1 line, -4 lines	0 comments	Download
M	src/objects.cc	View	1	8 chunks	+12 lines, -10 lines	0 comments	Download
M	src/objects-inl.h	View	1	4 chunks	+6 lines, -19 lines	0 comments	Download
M	src/objects-visiting.h	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Erik Corry

9 years, 7 months ago (2011-05-02 13:56:07 UTC) #2

I think you need to get rid of Map::GetHeap and Code::GetHeap

Otherwise LGTM