Issue 6904039: Update the URL if the user cancels a beforeunload handler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6904039: Update the URL if the user cancels a beforeunload handler. (Closed)

Created:
9 years, 8 months ago by Charlie Reis

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, Avi (use Gerrit), jam, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Update the URL if the user cancels a beforeunload handler. BUG=80401 TEST=BrowserTest.CancelBeforeUnloadResetsURL Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83388

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -3 lines)			Patch
M	chrome/browser/browser_browsertest.cc	View	1 2	3 chunks	+33 lines, -0 lines	0 comments	Download
A	chrome/test/data/beforeunload.html	View	1 2	1 chunk	+11 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_delegate.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.cc	View		2 chunks	+8 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

Charlie Reis

Here's the first part of the fix. Still needs a test, and I'd like to ...

9 years, 8 months ago (2011-04-27 01:05:23 UTC) #1

brettw

This approach makes sense, let me know when your final patch is ready.

9 years, 8 months ago (2011-04-28 05:58:32 UTC) #2

Charlie Reis

Thanks. The new test is passing on the try bots, so I think we should ...

9 years, 8 months ago (2011-04-28 15:38:07 UTC) #3

LGTM