Issue 690393003: ServiceWorker: Remove outdated InstallEvent::replace()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 690393003: ServiceWorker: Remove outdated InstallEvent::replace() (Closed)

Created:
6 years, 1 month ago by nhiroki

Modified:
6 years, 1 month ago

Reviewers:
falken

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

ServiceWorker: Remove outdated InstallEvent::replace() This function was removed from the spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#install-event-section BUG=423600 TEST=n/a Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185101

Patch Set 1 : #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -10 lines)			Patch
M	Source/modules/serviceworkers/InstallEvent.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/modules/serviceworkers/InstallEvent.cpp	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	Source/modules/serviceworkers/InstallEvent.idl	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690393003/20001

6 years, 1 month ago (2014-11-11 03:51:35 UTC) #6

commit-bot: I haz the power

6 years, 1 month ago (2014-11-11 04:45:37 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:20001) as 185101

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages