Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: extensions/browser/api/cast_channel/cast_channel_api.cc

Issue 690383002: cast channel error cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review feedback changes. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/cast_channel/cast_channel_api.cc
diff --git a/extensions/browser/api/cast_channel/cast_channel_api.cc b/extensions/browser/api/cast_channel/cast_channel_api.cc
index c2c083c79cfe234a4040486b111dbcf7f4e0963c..08134ffb97d81445e3c59fda228dd589cf99169b 100644
--- a/extensions/browser/api/cast_channel/cast_channel_api.cc
+++ b/extensions/browser/api/cast_channel/cast_channel_api.cc
@@ -172,8 +172,8 @@ void CastChannelAPI::OnMessage(const CastSocket* socket,
CastChannelAPI::~CastChannelAPI() {}
-CastChannelAsyncApiFunction::CastChannelAsyncApiFunction()
- : manager_(NULL), error_(cast_channel::CHANNEL_ERROR_NONE) { }
+CastChannelAsyncApiFunction::CastChannelAsyncApiFunction() : manager_(NULL) {
+}
CastChannelAsyncApiFunction::~CastChannelAsyncApiFunction() { }
@@ -183,7 +183,7 @@ bool CastChannelAsyncApiFunction::PrePrepare() {
}
bool CastChannelAsyncApiFunction::Respond() {
- return error_ == cast_channel::CHANNEL_ERROR_NONE;
+ return GetError().empty();
}
CastSocket* CastChannelAsyncApiFunction::GetSocketOrCompleteWithError(
@@ -216,7 +216,10 @@ void CastChannelAsyncApiFunction::SetResultFromSocket(
const CastSocket& socket) {
ChannelInfo channel_info;
FillChannelInfo(socket, &channel_info);
- error_ = socket.error_state();
+ ChannelError error = socket.error_state();
+ if (error != cast_channel::CHANNEL_ERROR_NONE) {
+ SetError("Channel socket error = " + base::IntToString(error));
+ }
SetResultFromChannelInfo(channel_info);
}
@@ -231,7 +234,7 @@ void CastChannelAsyncApiFunction::SetResultFromError(int channel_id,
channel_info.connect_info.port = 0;
channel_info.connect_info.auth = cast_channel::CHANNEL_AUTH_TYPE_SSL;
SetResultFromChannelInfo(channel_info);
- error_ = error;
+ SetError("Channel error = " + base::IntToString(error));
}
CastSocket* CastChannelAsyncApiFunction::GetSocket(int channel_id) {
« no previous file with comments | « extensions/browser/api/cast_channel/cast_channel_api.h ('k') | extensions/browser/api/cast_channel/cast_channel_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698