chrome/test/data/extensions/api_test/cast_channel/api/test_open_error.js - Issue 690383002: cast channel error cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/cast_channel/api/test_open_error.js

Issue 690383002: cast channel error cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review feedback changes. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/cast_channel/api/test_authority_keys.js ('k') | extensions/browser/api/cast_channel/cast_channel_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/cast_channel/api/test_open_error.js

diff --git a/chrome/test/data/extensions/api_test/cast_channel/api/test_open_error.js b/chrome/test/data/extensions/api_test/cast_channel/api/test_open_error.js

index 1cb7e4bacf31f6b0fe0331ecf0a74f41397af748..2a2c17a64aa2454bcc33fdecaf76885bcdb6228e 100644

--- a/chrome/test/data/extensions/api_test/cast_channel/api/test_open_error.js

+++ b/chrome/test/data/extensions/api_test/cast_channel/api/test_open_error.js

@@ -6,7 +6,7 @@ var errorEvent = false;

var openCallback = false;

var onClose = function(channel) {

- chrome.test.assertLastError('Unknown error.');

+ chrome.test.assertLastError('Channel socket error = 3');

assertClosedChannelWithError(channel, 'connect_error');

chrome.test.succeed();

}

@@ -21,7 +21,7 @@ var onError = function(channel, error) {

}

var onOpen = function(channel) {

- chrome.test.assertLastError('Unknown error.');

+ chrome.test.assertLastError('Channel socket error = 3');

openCallback = true;

assertClosedChannelWithError(channel, 'connect_error');

maybeClose(channel);