Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: extensions/browser/api/cast_channel/cast_channel_api.h

Issue 690383002: cast channel error cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review changes. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/cast_channel/cast_channel_api.h
diff --git a/extensions/browser/api/cast_channel/cast_channel_api.h b/extensions/browser/api/cast_channel/cast_channel_api.h
index ebaf41867c7461caa50fc4d44f6b4d9916e30014..64da7eb4c0258ce3545ee4b81cad9ec9abbf1ad6 100644
--- a/extensions/browser/api/cast_channel/cast_channel_api.h
+++ b/extensions/browser/api/cast_channel/cast_channel_api.h
@@ -116,8 +116,9 @@ class CastChannelAsyncApiFunction : public AsyncApiFunction {
void SetResultFromSocket(const cast_channel::CastSocket& socket);
// Sets the function result to a ChannelInfo populated with |channel_id| and
- // |error|.
- void SetResultFromError(int channel_id, cast_channel::ChannelError error);
+ // |channel_error|.
+ void SetResultFromError(int channel_id,
+ cast_channel::ChannelError channel_error);
// Returns the socket corresponding to |channel_id| if one exists, or null
// otherwise.
@@ -130,8 +131,8 @@ class CastChannelAsyncApiFunction : public AsyncApiFunction {
// The API resource manager for CastSockets.
ApiResourceManager<cast_channel::CastSocket>* manager_;
- // The result of the function.
- cast_channel::ChannelError error_;
+ // Whether the api function generated a channel error.
+ bool is_channel_error_;
};
class CastChannelOpenFunction : public CastChannelAsyncApiFunction {

Powered by Google App Engine
This is Rietveld 408576698