Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 690373002: Revert of WebView Guest should use ZOOM_MODE_ISOLATED. (Closed)

Created:
6 years, 1 month ago by wjmaclean
Modified:
6 years, 1 month ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, sergeygs
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of WebView Guest should use ZOOM_MODE_ISOLATED. (patchset #2 id:100001 of https://codereview.chromium.org/645153002/) Reason for revert: This CL seems to be at the root of several other issues, including https://code.google.com/p/chromium/issues/detail?id=429004. In particular, it seems to be allowing re-entrancy into ZoomController that was unexpected due to the timing with which OnGuestReady() is called. Original issue's description: > WebView Guest should use ZOOM_MODE_ISOLATED. > > In order that changes to zoom levels in a WebView Guest don't affect > the embedder, set the WebView Guest's WebContents to use > ZOOM_MODE_ISOLATED. > > BUG=418605 > > Committed: https://crrev.com/f71a5dc79473cc74990d1e288c66ac282c2926a1 > Cr-Commit-Position: refs/heads/master@{#299493} TBR=fsamuel@chromium.org NOTREECHECKS=true NOTRY=true BUG=418605 Committed: https://crrev.com/82c6af625500a7bfdcf9f619c4e5702fa12f2b40 Cr-Commit-Position: refs/heads/master@{#302332}

Patch Set 1 #

Patch Set 2 : Manual rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest_delegate.h View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
wjmaclean
Created Revert of WebView Guest should use ZOOM_MODE_ISOLATED.
6 years, 1 month ago (2014-10-31 21:38:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690373002/1
6 years, 1 month ago (2014-10-31 21:39:35 UTC) #2
commit-bot: I haz the power
Failed to apply patch for chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc: While running git apply --index -3 -p1; error: patch ...
6 years, 1 month ago (2014-10-31 21:40:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690373002/130001
6 years, 1 month ago (2014-10-31 21:58:52 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:130001)
6 years, 1 month ago (2014-10-31 22:00:23 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 22:01:41 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/82c6af625500a7bfdcf9f619c4e5702fa12f2b40
Cr-Commit-Position: refs/heads/master@{#302332}

Powered by Google App Engine
This is Rietveld 408576698