Issue 690363002: Make clicking links work in SkyDB

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 690363002: Make clicking links work in SkyDB (Closed)

Created:
6 years, 1 month ago by abarth-chromium

Modified:
6 years, 1 month ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, esprehn

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Make clicking links work in SkyDB Now the SkyDebugger implements NavigatorHost and actually navigates the mojo::View. This CL pulled a big refactor of sky/tools/debugger to separate out MojoMain from debugger.cc. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/755861fc1fca371225b9709295d94e8ed738e012

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+247 lines, -120 lines)			Patch
M	sky/tools/debugger/BUILD.gn	View	2 chunks	+5 lines, -0 lines	0 comments	Download
A +	sky/tools/debugger/DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
A	sky/tools/debugger/debugger.h	View	1 chunk	+80 lines, -0 lines	0 comments	Download
M	sky/tools/debugger/debugger.cc	View	1 chunk	+86 lines, -117 lines	0 comments	Download
M	sky/tools/debugger/focus_rules.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	sky/tools/debugger/focus_rules.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
A +	sky/tools/debugger/main.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
A	sky/tools/debugger/navigator_host_impl.h	View	1 chunk	+37 lines, -0 lines	0 comments	Download
A	sky/tools/debugger/navigator_host_impl.cc	View	1 chunk	+31 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

abarth-chromium

6 years, 1 month ago (2014-10-31 20:17:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
755861fc1fca371225b9709295d94e8ed738e012 (presubmit successful).