Fixed crash caused from invalid URLs in the PageInfo dialog

Fixed crash caused from invalid URLs in the PageInfo dialog

Cleaned up WebsiteSettingsPopup::updatePageDetails in the PageInfo
dialog and fixed a crash from invalid URLs. When a malformed URL is
accessed, the PageInfo dialog will still display the URL, but won't
apply any custom coloring (this only applies to well-formed URLs).

TEST=Visit a malformed URL, such as 'data:html,foo<script', and open the
PageInfo dialog by long-pressing on the URL. The URL should be displayed
(but not colored), and Chrome should not crash.
BUG=427566
Committed: https://crrev.com/c1ab2b10ac0d9ffc067d521299504d8a9fbcebdb
Cr-Commit-Position: refs/heads/master@{#302743}

[sashab, 2014-11-03 02:43:06]

sashab@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Ted C, 2014-11-03 19:53:50]

https://codereview.chromium.org/690343003/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java
(right):

https://codereview.chromium.org/690343003/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java:262:
URI parsedUrl = new URI(mFullUrl);
URI parsing isn't a cheap task, so you should only do it a single time at the
top and null check it below.

https://codereview.chromium.org/690343003/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java:291:
mUrlTitle.setText(urlBuilder);
Also I would move this and the urlBuilder into the non-null URI case and have
the null URI case just call setText with mFullUrl.

[Ted C, 2014-11-05 01:03:41]

lgtm

[sashab, 2014-11-05 01:05:22]

https://codereview.chromium.org/690343003/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java
(right):

https://codereview.chromium.org/690343003/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java:262:
URI parsedUrl = new URI(mFullUrl);
On 2014/11/03 19:53:50, Ted C wrote:
> URI parsing isn't a cheap task, so you should only do it a single time at the
> top and null check it below.

Done.

https://codereview.chromium.org/690343003/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java:291:
mUrlTitle.setText(urlBuilder);
On 2014/11/03 19:53:50, Ted C wrote:
> Also I would move this and the urlBuilder into the non-null URI case and have
> the null URI case just call setText with mFullUrl.

Done.

[sashab, 2014-11-05 01:05:30]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2014-11-05 01:07:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/690343003/20001

[commit-bot: I haz the power, 2014-11-05 02:08:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-05 02:11:08]

Patchset 2 (id:??) landed as
https://crrev.com/c1ab2b10ac0d9ffc067d521299504d8a9fbcebdb
Cr-Commit-Position: refs/heads/master@{#302743}