Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 69033004: Don't set "print selection" to false. (Closed)

Created:
7 years, 1 month ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 1 month ago
Reviewers:
Noam Samuel
CC:
chromium-reviews
Visibility:
Public.

Description

Don't set "print selection" to false. Before r231501 "print selection" was setup after InitPrintSettings. So reseting to false was OK. Now option is already there so we need to keep it. BUG=317851 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234444

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M printing/printing_context_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Vitaly Buka (NO REVIEWS)
7 years, 1 month ago (2013-11-11 21:48:20 UTC) #1
Noam Samuel
lgtm
7 years, 1 month ago (2013-11-11 21:49:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/69033004/1
7 years, 1 month ago (2013-11-11 21:51:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/69033004/1
7 years, 1 month ago (2013-11-12 06:39:16 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-12 07:09:09 UTC) #5
Message was sent while issue was closed.
Change committed as 234444

Powered by Google App Engine
This is Rietveld 408576698