Issue 690313002: Override IsRedirectResponse in extension protocols

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 690313002: Override IsRedirectResponse in extension protocols (Closed)

Created:
6 years, 1 month ago by robwu

Modified:
6 years, 1 month ago

Reviewers:

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2171

Project:
chromium

Visibility:
Public.

Override IsRedirectResponse in extension protocols The default URLFileRequestJob::IsRedirectResponse implementation is incorrect for URLRequestExtensionJob (chrome-extension:-scheme) and ExtensionResourcesJob (chrome-extension-resource:-scheme). BUG=388852, 424961 Review URL: https://codereview.chromium.org/650453003 Cr-Commit-Position: refs/heads/master@{#300329} (cherry picked from commit 54a4e4044b90ab88d59af098586cd82bc1cfac8e) Committed: https://chromium.googlesource.com/chromium/src/+/9929eff121903c9a3c627696fd91b9082c1d372b

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	chrome/browser/extensions/extension_resource_protocols.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download
	M	extensions/browser/extension_protocols.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

robwu

6 years, 1 month ago (2014-10-31 15:28:43 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9929eff121903c9a3c627696fd91b9082c1d372b.