Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 6903127: [Sync] Add support for enabling/disabling an extension before it's installed (Closed)

Created:
9 years, 8 months ago by akalin
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

[Sync] Add support for enabling/disabling an extension before it's installed Make Enable/DisableExtension handle non-installed extensions gracefully. Make DisableExtension handle terminated extensions. Make ProcessSyncData enable/disable an extension regardless of whether it's already installed. BUG=72659 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83571

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -38 lines) Patch
M chrome/browser/extensions/extension_pref_value_map.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 4 chunks +47 lines, -34 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
akalin
+asargent for review
9 years, 8 months ago (2011-04-29 00:14:29 UTC) #1
asargent_no_longer_on_chrome
LGTM http://codereview.chromium.org/6903127/diff/1/chrome/browser/extensions/extension_service.h File chrome/browser/extensions/extension_service.h (right): http://codereview.chromium.org/6903127/diff/1/chrome/browser/extensions/extension_service.h#newcode279 chrome/browser/extensions/extension_service.h:279: // Enabled the extension. If the extension is ...
9 years, 7 months ago (2011-04-29 17:12:59 UTC) #2
akalin
Committing http://codereview.chromium.org/6903127/diff/1/chrome/browser/extensions/extension_service.h File chrome/browser/extensions/extension_service.h (right): http://codereview.chromium.org/6903127/diff/1/chrome/browser/extensions/extension_service.h#newcode279 chrome/browser/extensions/extension_service.h:279: // Enabled the extension. If the extension is ...
9 years, 7 months ago (2011-04-29 18:29:42 UTC) #3
commit-bot: I haz the power
9 years, 7 months ago (2011-04-29 19:27:34 UTC) #4
Change committed as 83571

Powered by Google App Engine
This is Rietveld 408576698