Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Issue 690283002: Add null check for entries of volume items. (Closed)

Created:
6 years, 1 month ago by fukino
Modified:
6 years, 1 month ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add null check for entries of volume items. VolumeItem.entry can be null in FSP volume, so this CL add null check before using them. Also, make some annotation strict to detect missing null check in static analysis. BUG=427819 TEST=Force VolumeItem.entry to be null manually and confirm that no error rises. Committed: https://crrev.com/8f814cf5c21d6476349efda2f1c09489486a16eb Cr-Commit-Position: refs/heads/master@{#302277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -16 lines) Patch
M ui/file_manager/file_manager/common/js/util.js View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/directory_tree.js View 14 chunks +19 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
fukino
Tomasz, could you take a look? Thanks!
6 years, 1 month ago (2014-10-31 14:57:43 UTC) #2
mtomasz
lgtm
6 years, 1 month ago (2014-10-31 15:17:30 UTC) #3
fukino
On 2014/10/31 15:17:30, mtomasz wrote: > lgtm Thanks!
6 years, 1 month ago (2014-10-31 15:20:10 UTC) #4
fukino
On 2014/10/31 15:17:30, mtomasz wrote: > lgtm Thanks!
6 years, 1 month ago (2014-10-31 15:20:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690283002/1
6 years, 1 month ago (2014-10-31 15:20:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 16:12:22 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 16:13:01 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f814cf5c21d6476349efda2f1c09489486a16eb
Cr-Commit-Position: refs/heads/master@{#302277}

Powered by Google App Engine
This is Rietveld 408576698