Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1359)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 690263003: <webview>: Remove broken captureVisibleRegion code until feature is properly supported (Closed)

Created:
6 years, 1 month ago by Fady Samuel
Modified:
6 years, 1 month ago
Reviewers:
nasko
CC:
chromium-reviews, extensions-reviews_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

<webview>: Remove broken captureVisibleRegion code until feature is properly supported BUG=430096 TBR=nasko@chromium.org for render_widget_host_view_guest.* TBR=kenrb@chromium.org for browser_plugin_messages.h TBR=lazyboy@chromium.org for overall. Committed: https://crrev.com/446daa3a8fe9f90c89fdc040ff44c5b47bcfa1b9 Cr-Commit-Position: refs/heads/master@{#302623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -210 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.h View 3 chunks +1 line, -16 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 5 chunks +0 lines, -29 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M content/common/browser_plugin/browser_plugin_messages.h View 2 chunks +0 lines, -11 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 3 chunks +0 lines, -20 lines 0 comments Download
M content/renderer/child_frame_compositing_helper.h View 3 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/child_frame_compositing_helper.cc View 2 chunks +0 lines, -38 lines 0 comments Download
M extensions/browser/api/web_view/web_view_internal_api.h View 1 chunk +0 lines, -19 lines 0 comments Download
M extensions/browser/api/web_view/web_view_internal_api.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M extensions/common/api/web_view_internal.json View 1 chunk +0 lines, -22 lines 0 comments Download
M extensions/renderer/resources/guest_view/web_view_experimental.js View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Fady Samuel
This is a pure code deletion patch so I'm TBR'ing the appropriate folks.
6 years, 1 month ago (2014-11-04 15:48:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690263003/1
6 years, 1 month ago (2014-11-04 15:49:56 UTC) #3
nasko
LGTM
6 years, 1 month ago (2014-11-04 16:53:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 17:33:03 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 17:33:39 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/446daa3a8fe9f90c89fdc040ff44c5b47bcfa1b9
Cr-Commit-Position: refs/heads/master@{#302623}

Powered by Google App Engine
This is Rietveld 408576698