Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Side by Side Diff: Source/bindings/core/v8/V8Binding.h

Issue 690243002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/bindings/core/v8/V8Binding.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Ericsson AB. All rights reserved. 3 * Copyright (C) 2012 Ericsson AB. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 class XPathNSResolver; 60 class XPathNSResolver;
61 61
62 namespace TraceEvent { 62 namespace TraceEvent {
63 class ConvertableToTraceFormat; 63 class ConvertableToTraceFormat;
64 } 64 }
65 65
66 const int kMaxRecursionDepth = 22; 66 const int kMaxRecursionDepth = 22;
67 67
68 // Helpers for throwing JavaScript TypeErrors for arity mismatches. 68 // Helpers for throwing JavaScript TypeErrors for arity mismatches.
69 void setArityTypeError(ExceptionState&, const char* valid, unsigned provided); 69 void setArityTypeError(ExceptionState&, const char* valid, unsigned provided);
70 v8::Local<v8::Value> createMinimumArityTypeErrorForMethod(const char* method, co nst char* type, unsigned expected, unsigned provided, v8::Isolate*); 70 v8::Local<v8::Value> createMinimumArityTypeErrorForMethod(v8::Isolate*, const ch ar* method, const char* type, unsigned expected, unsigned provided);
71 v8::Local<v8::Value> createMinimumArityTypeErrorForConstructor(const char* type, unsigned expected, unsigned provided, v8::Isolate*); 71 v8::Local<v8::Value> createMinimumArityTypeErrorForConstructor(v8::Isolate*, con st char* type, unsigned expected, unsigned provided);
72 void setMinimumArityTypeError(ExceptionState&, unsigned expected, unsigned provi ded); 72 void setMinimumArityTypeError(ExceptionState&, unsigned expected, unsigned provi ded);
73 73
74 v8::ArrayBuffer::Allocator* v8ArrayBufferAllocator(); 74 v8::ArrayBuffer::Allocator* v8ArrayBufferAllocator();
75 75
76 template<typename CallbackInfo, typename S> 76 template<typename CallbackInfo, typename S>
77 inline void v8SetReturnValue(const CallbackInfo& info, const v8::Persistent<S>& handle) 77 inline void v8SetReturnValue(const CallbackInfo& info, const v8::Persistent<S>& handle)
78 { 78 {
79 info.GetReturnValue().Set(handle); 79 info.GetReturnValue().Set(handle);
80 } 80 }
81 81
(...skipping 1117 matching lines...) Expand 10 before | Expand all | Expand 10 after
1199 v8::Local<v8::Value> v8IteratorResult(ScriptState* scriptState, const T& value) 1199 v8::Local<v8::Value> v8IteratorResult(ScriptState* scriptState, const T& value)
1200 { 1200 {
1201 return v8IteratorResult(scriptState->isolate(), V8ValueTraits<T>::toV8Value( value, scriptState->context()->Global(), scriptState->isolate())); 1201 return v8IteratorResult(scriptState->isolate(), V8ValueTraits<T>::toV8Value( value, scriptState->context()->Global(), scriptState->isolate()));
1202 } 1202 }
1203 1203
1204 typedef void (*InstallTemplateFunction)(v8::Handle<v8::FunctionTemplate>, v8::Is olate*); 1204 typedef void (*InstallTemplateFunction)(v8::Handle<v8::FunctionTemplate>, v8::Is olate*);
1205 1205
1206 } // namespace blink 1206 } // namespace blink
1207 1207
1208 #endif // V8Binding_h 1208 #endif // V8Binding_h
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/core/v8/V8Binding.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698