Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 690213003: Android: Remove a few more unneeded files from the build. (Closed)

Created:
6 years, 1 month ago by Lei Zhang
Modified:
6 years, 1 month ago
Reviewers:
tapted, Andre
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Android: Remove a few more unneeded files from the build. BUG=159847 Committed: https://crrev.com/31783d4f0dc2aea193d19cdd697b5e5e440d0c72 Cr-Commit-Position: refs/heads/master@{#302360}

Patch Set 1 #

Total comments: 3

Patch Set 2 : move #

Patch Set 3 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/chrome_browser_ui.gypi View 1 2 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Lei Zhang
https://codereview.chromium.org/690213003/diff/1/chrome/chrome_browser_ui.gypi File chrome/chrome_browser_ui.gypi (right): https://codereview.chromium.org/690213003/diff/1/chrome/chrome_browser_ui.gypi#newcode2233 chrome/chrome_browser_ui.gypi:2233: 'browser/ui/browser_window_state.cc', Please help me figure out if this belongs ...
6 years, 1 month ago (2014-10-31 09:30:49 UTC) #2
Andre
https://codereview.chromium.org/690213003/diff/1/chrome/chrome_browser_ui.gypi File chrome/chrome_browser_ui.gypi (right): https://codereview.chromium.org/690213003/diff/1/chrome/chrome_browser_ui.gypi#newcode2233 chrome/chrome_browser_ui.gypi:2233: 'browser/ui/browser_window_state.cc', On 2014/10/31 09:30:49, Lei Zhang wrote: > Please ...
6 years, 1 month ago (2014-10-31 17:11:46 UTC) #3
Lei Zhang
https://codereview.chromium.org/690213003/diff/1/chrome/chrome_browser_ui.gypi File chrome/chrome_browser_ui.gypi (right): https://codereview.chromium.org/690213003/diff/1/chrome/chrome_browser_ui.gypi#newcode2233 chrome/chrome_browser_ui.gypi:2233: 'browser/ui/browser_window_state.cc', On 2014/10/31 17:11:45, Andre wrote: > On 2014/10/31 ...
6 years, 1 month ago (2014-10-31 19:46:00 UTC) #4
Andre
lgtm
6 years, 1 month ago (2014-10-31 22:57:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690213003/40001
6 years, 1 month ago (2014-10-31 23:10:04 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-01 00:06:42 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-01 00:07:15 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/31783d4f0dc2aea193d19cdd697b5e5e440d0c72
Cr-Commit-Position: refs/heads/master@{#302360}

Powered by Google App Engine
This is Rietveld 408576698