Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: chrome/browser/sync/glue/extension_data.h

Issue 6902054: [Sync] Rip out overly-complicated ExtensionData class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed asargent's comments Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/extension_data.h
diff --git a/chrome/browser/sync/glue/extension_data.h b/chrome/browser/sync/glue/extension_data.h
deleted file mode 100644
index 73316deda8409e102c3c18e5c349b592e98d18a1..0000000000000000000000000000000000000000
--- a/chrome/browser/sync/glue/extension_data.h
+++ /dev/null
@@ -1,65 +0,0 @@
-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_SYNC_GLUE_EXTENSION_DATA_H_
-#define CHROME_BROWSER_SYNC_GLUE_EXTENSION_DATA_H_
-#pragma once
-
-// ExtensionData is the class used to manage the client and server
-// versions of the data for a particular extension.
-
-#include <map>
-
-#include "chrome/browser/sync/protocol/extension_specifics.pb.h"
-
-namespace browser_sync {
-
-class ExtensionData {
- public:
- enum Source {
- CLIENT,
- SERVER,
- };
-
- // Returns an ExtensionData constructed from the given data from the
- // given source. merged_data() will be equal to |data| and
- // NeedsUpdate(source) will return false.
- static ExtensionData FromData(
- Source source, const sync_pb::ExtensionSpecifics& data);
-
- ~ExtensionData();
-
- // Implicit copy constructor and assignment operator welcome.
-
- // Returns the version of the data that all sources should
- // eventually have.
- const sync_pb::ExtensionSpecifics& merged_data() const;
-
- // Returns whether or not the data from the given source needs to be
- // updated from merged_data().
- bool NeedsUpdate(Source source) const;
-
- // Stores the given data as being from the given source, merging it
- // into merged_data(). May change what NeedsUpdate() returns for
- // any source.
- void SetData(
- Source source, bool merge_user_properties,
- const sync_pb::ExtensionSpecifics& data);
-
- // Marks the data from the given data as updated,
- // i.e. NeedsUpdate(source) will return false.
- void ResolveData(Source source);
-
- private:
- typedef std::map<Source, sync_pb::ExtensionSpecifics> SourceDataMap;
- SourceDataMap source_data_;
- sync_pb::ExtensionSpecifics merged_data_;
-
- // This is private; clients must use FromData().
- ExtensionData();
-};
-
-} // namespace
-
-#endif // CHROME_BROWSER_SYNC_GLUE_EXTENSION_DATA_H_
« no previous file with comments | « chrome/browser/extensions/extension_sync_data_unittest.cc ('k') | chrome/browser/sync/glue/extension_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698