Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 690133003: Convert fast/multicol/vertical-rl/rule-style to reftest. (Closed)

Created:
6 years, 1 month ago by andersr
Modified:
6 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Convert fast/multicol/vertical-rl/rule-style to reftest. R=mstensho@opera.com BUG=386567 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184921

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unnecessary divs. #

Messages

Total messages: 7 (1 generated)
andersr
Strange that there's only a vertical-rl version of this test.
6 years, 1 month ago (2014-11-04 12:37:05 UTC) #1
mstensho (USE GERRIT)
lgtm with nit. https://codereview.chromium.org/690133003/diff/1/LayoutTests/fast/multicol/vertical-rl/rule-style-expected.html File LayoutTests/fast/multicol/vertical-rl/rule-style-expected.html (right): https://codereview.chromium.org/690133003/diff/1/LayoutTests/fast/multicol/vertical-rl/rule-style-expected.html#newcode16 LayoutTests/fast/multicol/vertical-rl/rule-style-expected.html:16: .rule > div { This selector ...
6 years, 1 month ago (2014-11-04 21:55:49 UTC) #2
andersr
https://codereview.chromium.org/690133003/diff/1/LayoutTests/fast/multicol/vertical-rl/rule-style-expected.html File LayoutTests/fast/multicol/vertical-rl/rule-style-expected.html (right): https://codereview.chromium.org/690133003/diff/1/LayoutTests/fast/multicol/vertical-rl/rule-style-expected.html#newcode16 LayoutTests/fast/multicol/vertical-rl/rule-style-expected.html:16: .rule > div { On 2014/11/04 21:55:49, mstensho wrote: ...
6 years, 1 month ago (2014-11-05 15:16:34 UTC) #3
mstensho (USE GERRIT)
Great, then it's ready for commit.
6 years, 1 month ago (2014-11-06 14:25:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690133003/20001
6 years, 1 month ago (2014-11-06 15:27:24 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 16:38:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184921

Powered by Google App Engine
This is Rietveld 408576698