Issue 690133002: Add support for directory listings in sky_server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 690133002: Add support for directory listings in sky_server. (Closed)

Created:
6 years, 1 month ago by eseidel

Modified:
6 years, 1 month ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add support for directory listings in sky_server. Unfortunate these aren't very useful since we can't actually click on links, nor do navigations work anyway... TBR=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/959e7227f01c4b54d0ed17b5c02f3359f9c90708

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+141 lines, -0 lines)			Patch
	M	sky/tools/sky_server	View		3 chunks	+21 lines, -0 lines	1 comment	Download
	A	sky/tools/staticdirindex.py	View		1 chunk	+120 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

eseidel

Committed patchset #1 (id:1) manually as 959e7227f01c4b54d0ed17b5c02f3359f9c90708 (presubmit successful).

6 years, 1 month ago (2014-10-30 22:38:35 UTC) #2

abarth-chromium

https://codereview.chromium.org/690133002/diff/1/sky/tools/sky_server File sky/tools/sky_server (right): https://codereview.chromium.org/690133002/diff/1/sky/tools/sky_server#newcode36 sky/tools/sky_server:36: return sky + "</listing>" So much the XSS

6 years, 1 month ago (2014-10-31 02:21:37 UTC) #3

abarth-chromium

sky/tools/staticdirindex.py I wonder if we should have put that in a third_party directory or something.

6 years, 1 month ago (2014-10-31 02:22:14 UTC) #4

eseidel

6 years, 1 month ago (2014-10-31 13:08:22 UTC) #5

Message was sent while issue was closed.

Happy to move the code to tools/third_party/staticlibdir with a LICENSE?  Or
honestly we could just re-write the 30 lines of code that is.

Expand Messages | Collapse Messages