Issue 69013004: Renamed CanPruneAllButVisible and PruneAllButVisible in the Navigation Controller to CanPruneAllBut…

Issue 69013004: Renamed CanPruneAllButVisible and PruneAllButVisible in the Navigation Controller to CanPruneAllBut… (Closed)

Created:
7 years, 1 month ago by jww

Modified:
7 years, 1 month ago

Reviewers:
Charlie Reis, jochen (gone - plz use gerrit)

CC:
chromium-reviews, davidben+watch_chromium.org, joi+watch-content_chromium.org, cbentzel+watch_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, tburkard+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jam, dominich, gavinp+prer_chromium.org, dominich+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, darin-cc_chromium.org, kmadhusu+watch_chromium.org, Jered

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Renamed CanPruneAllButVisible and PruneAllButVisible in the Navigation Controller to CanPruneAllButLastCommitted and PruneAllButLastCommitted, respectively. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234693

Patch Set 1 #

Patch Set 2 : Fixed some unit tests #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -43 lines)			Patch
M	chrome/browser/prerender/prerender_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/browser_commands.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser_instant_controller.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	content/browser/android/content_view_core_impl.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/frame_host/navigation_controller_impl.h	View		2 chunks	+7 lines, -6 lines	0 comments	Download
M	content/browser/frame_host/navigation_controller_impl.cc	View		5 chunks	+7 lines, -7 lines	0 comments	Download
M	content/browser/frame_host/navigation_controller_impl_unittest.cc	View	1	5 chunks	+13 lines, -13 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/browser/navigation_controller.h	View		2 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Charlie Reis

Yes, that's more accurate, now that we're using "visible" to refer to the URL rather ...

7 years, 1 month ago (2013-11-12 00:02:09 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/69013004/1

7 years, 1 month ago (2013-11-12 17:25:01 UTC) #5

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=188536

7 years, 1 month ago (2013-11-12 17:55:54 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/69013004/300001

7 years, 1 month ago (2013-11-12 19:13:16 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jww@chromium.org/69013004/300001

7 years, 1 month ago (2013-11-12 23:54:47 UTC) #8

Message was sent while issue was closed.

Change committed as 234693

Expand Messages | Collapse Messages