clang: Mention that the ctor/dtor needs "out of line" implementation.

tools/clang/plugins/FindBadConstructs.cpp

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file defines a bunch of recurring problems in the Chromium C++ code.
 //
 // Checks that are implemented:
 // - Constructors/Destructors should not be inlined if they are of a complex
 //   class type.
 // - Missing "virtual" keywords on methods that should be virtual.
@@ skipping 86 matching lines @@
     // The fourth normal class member should trigger the warning.
     dtor_score += non_trivial_member * 3;
 
     int ctor_score = dtor_score;
     // You should be able to have 9 ints before we warn you.
     ctor_score += trivial_member;
 
     if (ctor_score >= 10) {
       if (!record->hasUserDeclaredConstructor()) {
         emitWarning(record_location,
-                    "Complex class/struct needs a declared constructor.");
+                    "Complex class/struct needs an explicit out-of-line "
+                    "constructor.");
       } else {
         // Iterate across all the constructors in this file and yell if we
         // find one that tries to be inline.
         for (CXXRecordDecl::ctor_iterator it = record->ctor_begin();
              it != record->ctor_end(); ++it) {
           if (it->hasInlineBody()) {
             emitWarning(it->getInnerLocStart(),
                         "Complex constructor has an inlined body.");
           }
         }
       }
     }
 
     // The destructor side is equivalent except that we don't check for
     // trivial members; 20 ints don't need a destructor.
     if (dtor_score >= 10 && !record->hasTrivialDestructor()) {
       if (!record->hasUserDeclaredDestructor()) {
-        emitWarning(record_location,
-                    "Complex class/struct needs a declared destructor.");
+        emitWarning(
+            record_location,
+            "Complex class/struct needs a needs an explicit out-of-line "
+            "destructor.");
       } else if (CXXDestructorDecl* dtor = record->getDestructor()) {
         if (dtor->hasInlineBody()) {
           emitWarning(dtor->getInnerLocStart(),
                       "Complex destructor has an inline body.");
         }
       }
     }
   }
 
   // Makes sure there is a "virtual" keyword on virtual methods and that there
@@ skipping 116 matching lines @@
                  const std::vector<std::string>& args) {
     // We don't take any additional arguments here.
     return true;
   }
 };
 
 }  // namespace
 
 static FrontendPluginRegistry::Add<FindBadConstructsAction>
 X("find-bad-constructs", "Finds bad C++ constructs");