clang: Mention that the ctor/dtor needs "out of line" implementation.

clang: Mention that the ctor/dtor needs "out of line" implementation.

BUG=78743
TEST=None

R=erg@chromium.org,thakis@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83397

[Elliot Glaysher, 2011-04-28 16:52:53]

You also need to update the test expectations...

On Thu, Apr 28, 2011 at 9:46 AM,  <tfarina@chromium.org> wrote:
> Reviewers: Nico, Elliot Glaysher,
>
> Description:
> clang: Mention that the destructor needs "out of line" implementation.
>
> BUG=78743
> TEST=None
>
> R=thakis@chromium.org,erg@chromium.org
>
>
> Please review this at http://codereview.chromium.org/6901095/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M tools/clang/plugins/FindBadConstructs.cpp
>
>
> Index: tools/clang/plugins/FindBadConstructs.cpp
> diff --git a/tools/clang/plugins/FindBadConstructs.cpp
> b/tools/clang/plugins/FindBadConstructs.cpp
> index
>
d7bcdaee02de27ed557cb3bc6b153c070d076211..d71d49e3c68504c40fef9da523579d86a3c54918
> 100644
> --- a/tools/clang/plugins/FindBadConstructs.cpp
> +++ b/tools/clang/plugins/FindBadConstructs.cpp
> @@ -104,7 +104,8 @@ class FindBadConstructsConsumer : public
> ChromeClassTester {
>     if (ctor_score >= 10) {
>       if (!record->hasUserDeclaredConstructor()) {
>         emitWarning(record_location,
> -                    "Complex class/struct needs a declared constructor.");
> +                    "Complex class/struct needs an explicit out-of-line "
> +                    "destructor.");
>       } else {
>         // Iterate across all the constructors in this file and yell if we
>         // find one that tries to be inline.
> @@ -122,8 +123,10 @@ class FindBadConstructsConsumer : public
> ChromeClassTester {
>     // trivial members; 20 ints don't need a destructor.
>     if (dtor_score >= 10 && !record->hasTrivialDestructor()) {
>       if (!record->hasUserDeclaredDestructor()) {
> -        emitWarning(record_location,
> -                    "Complex class/struct needs a declared destructor.");
> +        emitWarning(
> +            record_location,
> +            "Complex class/struct needs a needs an explicit out-of-line "
> +            "destructor.");
>       } else if (CXXDestructorDecl* dtor = record->getDestructor()) {
>         if (dtor->hasInlineBody()) {
>           emitWarning(dtor->getInnerLocStart(),
>
>
>

[tfarina, 2011-04-28 16:57:35]

On 2011/04/28 16:52:53, Elliot Glaysher wrote:
> You also need to update the test expectations...
> 
Updated.

[Elliot Glaysher, 2011-04-28 20:26:41]

On 2011/04/28 16:57:35, tfarina wrote:
> On 2011/04/28 16:52:53, Elliot Glaysher wrote:
> > You also need to update the test expectations...
> > 
> Updated.

Sure.

[tfarina, 2011-04-28 20:29:32]

On 2011/04/28 20:26:41, Elliot Glaysher wrote:
> On 2011/04/28 16:57:35, tfarina wrote:
> > On 2011/04/28 16:52:53, Elliot Glaysher wrote:
> > > You also need to update the test expectations...
> > > 
> > Updated.
> 
> Sure.

Could you send me your LGTM? ;) (So I don't get warnings when landing this
later).

[Elliot Glaysher, 2011-04-28 20:30:53]

LGTM

On Thu, Apr 28, 2011 at 1:29 PM,  <tfarina@chromium.org> wrote:
> On 2011/04/28 20:26:41, Elliot Glaysher wrote:
>>
>> On 2011/04/28 16:57:35, tfarina wrote:
>> > On 2011/04/28 16:52:53, Elliot Glaysher wrote:
>> > > You also need to update the test expectations...
>> > >
>> > Updated.
>
>> Sure.
>
> Could you send me your LGTM? ;) (So I don't get warnings when landing this
> later).
>
> http://codereview.chromium.org/6901095/
>