Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 6901095: clang: Mention that the ctor/dtor needs "out of line" implementation. (Closed)

Created:
9 years, 8 months ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
Nico, Elliot Glaysher
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

clang: Mention that the ctor/dtor needs "out of line" implementation. BUG=78743 TEST=None R=erg@chromium.org,thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83397

Patch Set 1 : #

Patch Set 2 : update test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M tools/clang/plugins/FindBadConstructs.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M tools/clang/plugins/tests/missing_ctor.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
9 years, 8 months ago (2011-04-28 16:46:22 UTC) #1
Elliot Glaysher
You also need to update the test expectations... On Thu, Apr 28, 2011 at 9:46 ...
9 years, 8 months ago (2011-04-28 16:52:53 UTC) #2
tfarina
On 2011/04/28 16:52:53, Elliot Glaysher wrote: > You also need to update the test expectations... ...
9 years, 8 months ago (2011-04-28 16:57:35 UTC) #3
Elliot Glaysher
On 2011/04/28 16:57:35, tfarina wrote: > On 2011/04/28 16:52:53, Elliot Glaysher wrote: > > You ...
9 years, 8 months ago (2011-04-28 20:26:41 UTC) #4
tfarina
On 2011/04/28 20:26:41, Elliot Glaysher wrote: > On 2011/04/28 16:57:35, tfarina wrote: > > On ...
9 years, 8 months ago (2011-04-28 20:29:32 UTC) #5
Elliot Glaysher
9 years, 8 months ago (2011-04-28 20:30:53 UTC) #6
LGTM

On Thu, Apr 28, 2011 at 1:29 PM,  <tfarina@chromium.org> wrote:
> On 2011/04/28 20:26:41, Elliot Glaysher wrote:
>>
>> On 2011/04/28 16:57:35, tfarina wrote:
>> > On 2011/04/28 16:52:53, Elliot Glaysher wrote:
>> > > You also need to update the test expectations...
>> > >
>> > Updated.
>
>> Sure.
>
> Could you send me your LGTM? ;) (So I don't get warnings when landing this
> later).
>
> http://codereview.chromium.org/6901095/
>

Powered by Google App Engine
This is Rietveld 408576698