Increase infobar height and infobar button height for touch.

Increase infobar height and infobar button height for touch.

#ifdef TOUCH_UI alternative constants were added for infobar height
and the button border padding.  All the other changes are supplying
"large" icon resources following http://codereview.chromium.org/6849030/

The new .png files added are simply the original icons scaled up with
ImageMagick by a factor of 2 (with Mitchell filtering).  I imagine
these will need to be replaced.

Contributed by rhashimoto@chromium.org

Committed as http://codereview.chromium.org/6902156/

BUG=none
TEST=none

[rhashimoto, 2011-04-28 15:54:21]

Please review these changes for resizing the info bar and its buttons for touch.

estade: InfoBarView and InfoBarButton border #ifdef constant changes.

sail: .grd split for standard and large info bar icons.

Currently the two .grd files point to the existing regular-size icons to keep
the trybots happy.  I will update theme_resources_large.grd when ready to
commit.

I have two questions:

1. Some lines in the .grd files are over 80 columns in length, both existing
ones and ones I added.  Should these be changed for the coding style or are they
okay because xml files are not code?

2. infobar_translate.png in the .grd file has two locations switched on
"pp_ifdef('_google_chrome')", apparently for chrome vs. chromium branding. 
There is only one such file in the tree and I created a large version of that
icon.  Does another branding icon need to be created somewhere else?

Thanks,
Roy

[sail, 2011-04-28 16:11:26]

> sail: .grd split for standard and large info bar icons.
LGTM. Please file a bug to remind yourself to update the scaled up icon. I find
what works for me is to file a bug on my self and bug the art guys to deliver
the new art.

> 1. Some lines in the .grd files are over 80 columns in length, both existing
> ones and ones I added.  Should these be changed for the coding style or are
they
> okay because xml files are not code?
Going over 80 lines in the GRD file is ok.

> 2. infobar_translate.png in the .grd file has two locations switched on
> "pp_ifdef('_google_chrome')", apparently for chrome vs. chromium branding. 
> There is only one such file in the tree and I created a large version of that
> icon.  Does another branding icon need to be created somewhere else?
I'll IM you on how to fix the other icon.

[saintlou, 2011-04-28 16:11:30]

Hi Roy

I do not understand why chrome/app/theme/theme_resources_large.grd	 contains
references to standard icons. This should work or we need to fix something else
before we submit.

Regarding #2 yes several assets are switched based on vs it a Chrome or Chromium
builds, the app logo/icon for example. In this case I do not understand why the
asset "infobar_translate.png" is considered a 'brandable' asset. I would check
with glen@ or others if this can be moved to a non-brand based folder

As for the temporary assets that is fine, we can ask designers to provide larger
versions and submit later.

-- Emmanuel

[sail, 2011-04-28 16:16:07]

> I do not understand why chrome/app/theme/theme_resources_large.grd	 contains
> references to standard icons. This should work or we need to fix something
else
> before we submit.
I think that's just for the sake of the try bots. If you look at patch2 it
contains the correct references.

[saintlou, 2011-04-28 17:47:33]

LGTM

[rhashimoto, 2011-04-28 19:11:27]

Oops, estade is not responsible for views infobars.  Replacing with pkasting as
reviewer.

Peter, could you please look at the InfoBarView and InfoBarButtonBorder
#ifdef-ing of constants for touch?

Thanks,
Roy

[sail, 2011-04-28 19:23:56]

> Peter, could you please look at the InfoBarView and InfoBarButtonBorder
> #ifdef-ing of constants for touch?
Peter is out sick today, might be a day or two to get a reply.

[Peter Kasting, 2011-04-28 19:27:55]

LGTM.  In each file where you've added the #include
"theme_resources_standard.h", please check whether you can remove the #include
for "theme_resources.h".

[rhashimoto, 2011-04-28 21:35:16]

I will put the final theme_resources_large.grd in a separate CL so trybots will
work for testing that.


On 2011/04/28 16:11:26, sail wrote:
> > sail: .grd split for standard and large info bar icons.
> LGTM. Please file a bug to remind yourself to update the scaled up icon. I
find
> what works for me is to file a bug on my self and bug the art guys to deliver
> the new art.

Done: chromium-os:14623

On 2011/04/28 19:27:55, Peter Kasting wrote:
> LGTM.  In each file where you've added the #include
> "theme_resources_standard.h", please check whether you can remove the #include
> for "theme_resources.h".

Done.  Trybots are running but all are through the compile stage.

[Emmanuel Saint-loubert-Bié, 2011-04-29 18:09:26]

Submitting on your behalf as http://codereview.chromium.org/6902156/
You should manually close this issue
-- E