Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 6901058: Increase infobar height and infobar button height for touch. (Closed)

Created:
9 years, 8 months ago by rhashimoto
Modified:
9 years, 7 months ago
CC:
chromium-reviews, GeorgeY, Avi (use Gerrit), nkostylev+cc_chromium.org, stuartmorgan+watch_chromium.org, Erik does not do reviews, brettw-cc_chromium.org, jam, Aaron Boodman, pam+watch_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, Ilya Sherman, davemoore+watch_chromium.org, dhollowa
Visibility:
Public.

Description

Increase infobar height and infobar button height for touch. #ifdef TOUCH_UI alternative constants were added for infobar height and the button border padding. All the other changes are supplying "large" icon resources following http://codereview.chromium.org/6849030/ The new .png files added are simply the original icons scaled up with ImageMagick by a factor of 2 (with Mitchell filtering). I imagine these will need to be replaced. Contributed by rhashimoto@chromium.org Committed as http://codereview.chromium.org/6902156/ BUG=none TEST=none

Patch Set 1 #

Patch Set 2 : Undo inadvertant whitespace change at end of file. #

Patch Set 3 : Use existing icons so trybots work. Add missing theme_resources_standard.h includes. #

Patch Set 4 : Remove theme_resources.h from files that only need theme_resources_standard.h. #

Patch Set 5 : Just a check to make sure trunk merge does nothing. #

Patch Set 6 : Undo inadvertant merge changes (hopefully). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -40 lines) Patch
A chrome/app/theme/chromium/large_infobar_translate.png View Binary file 0 comments Download
A chrome/app/theme/large_close_bar.png View Binary file 0 comments Download
A chrome/app/theme/large_close_bar_h.png View Binary file 0 comments Download
A chrome/app/theme/large_close_bar_mask.png View Binary file 0 comments Download
A chrome/app/theme/large_close_bar_p.png View Binary file 0 comments Download
A chrome/app/theme/large_infobar_autofill.png View Binary file 0 comments Download
A chrome/app/theme/large_infobar_cookie.png View Binary file 0 comments Download
A chrome/app/theme/large_infobar_didyoumean.png View Binary file 0 comments Download
A chrome/app/theme/large_infobar_insecure.png View Binary file 0 comments Download
A chrome/app/theme/large_infobar_multiple_downloads.png View Binary file 0 comments Download
A chrome/app/theme/large_infobar_plugin.png View Binary file 0 comments Download
A chrome/app/theme/large_infobar_plugin_crashed.png View Binary file 0 comments Download
A chrome/app/theme/large_infobar_questionmark.png View Binary file 0 comments Download
A chrome/app/theme/large_infobar_restore.png View Binary file 0 comments Download
A chrome/app/theme/large_infobar_savepassword.png View Binary file 0 comments Download
A chrome/app/theme/large_infobar_theme.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 2 chunks +0 lines, -21 lines 0 comments Download
M chrome/app/theme/theme_resources_large.grd View 1 2 2 chunks +21 lines, -0 lines 0 comments Download
M chrome/app/theme/theme_resources_standard.grd View 2 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/alternate_nav_url_fetcher.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_cc_infobar_delegate.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/frame/bubble_frame_view.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/message_bubble.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_request_infobar_delegate.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/theme_installed_infobar_delegate.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/first_run/try_chrome_dialog_view.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/omnibox_search_hint.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager_delegate_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_installer_infobar_delegate.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_observer.cc View 1 2 3 4 5 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_ssl_helper.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_infobar_delegate.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_init.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/collected_cookies_infobar_delegate.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/custom_button.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/download/download_shelf_gtk.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/find_bar_gtk.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/download/download_shelf_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_installed_bubble.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/first_run_bubble.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/app_panel_browser_frame_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/infobar_button_border.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
rhashimoto
Please review these changes for resizing the info bar and its buttons for touch. estade: ...
9 years, 8 months ago (2011-04-28 15:54:21 UTC) #1
sail
> sail: .grd split for standard and large info bar icons. LGTM. Please file a ...
9 years, 8 months ago (2011-04-28 16:11:26 UTC) #2
saintlou
Hi Roy I do not understand why chrome/app/theme/theme_resources_large.grd contains references to standard icons. This should ...
9 years, 8 months ago (2011-04-28 16:11:30 UTC) #3
sail
> I do not understand why chrome/app/theme/theme_resources_large.grd contains > references to standard icons. This should ...
9 years, 8 months ago (2011-04-28 16:16:07 UTC) #4
saintlou
LGTM
9 years, 8 months ago (2011-04-28 17:47:33 UTC) #5
rhashimoto
Oops, estade is not responsible for views infobars. Replacing with pkasting as reviewer. Peter, could ...
9 years, 8 months ago (2011-04-28 19:11:27 UTC) #6
sail
> Peter, could you please look at the InfoBarView and InfoBarButtonBorder > #ifdef-ing of constants ...
9 years, 8 months ago (2011-04-28 19:23:56 UTC) #7
Peter Kasting
LGTM. In each file where you've added the #include "theme_resources_standard.h", please check whether you can ...
9 years, 8 months ago (2011-04-28 19:27:55 UTC) #8
rhashimoto
I will put the final theme_resources_large.grd in a separate CL so trybots will work for ...
9 years, 8 months ago (2011-04-28 21:35:16 UTC) #9
Emmanuel Saint-loubert-Bié
9 years, 7 months ago (2011-04-29 18:09:26 UTC) #10
Submitting on your behalf as http://codereview.chromium.org/6902156/
You should manually close this issue
-- E

Powered by Google App Engine
This is Rietveld 408576698