Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: base/crypto/signature_verifier_unittest.cc

Issue 69010: Disable the negative test cases in the test... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Only disable the EXPECT_FALSE(ok) lines Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/data/purify/base_unittests.exe.gtest.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/crypto/signature_verifier_unittest.cc
===================================================================
--- base/crypto/signature_verifier_unittest.cc (revision 13711)
+++ base/crypto/signature_verifier_unittest.cc (working copy)
@@ -238,7 +238,14 @@
EXPECT_TRUE(ok);
verifier.VerifyUpdate(bad_tbs_certificate, sizeof(bad_tbs_certificate));
ok = verifier.VerifyFinal();
+
+ // Purify disables digital signature verification, causing the Windows
+ // CryptoAPI function CryptVerifySignature to always succeed. So we can't
+ // check the signature verification results of the negative tests when
+ // running inside Purify. See http://crbug.com/10031.
+#ifndef PURIFY
EXPECT_FALSE(ok);
+#endif
// Test 4: verify a bad signature.
uint8 bad_signature[sizeof(signature)];
@@ -254,6 +261,8 @@
if (ok) {
verifier.VerifyUpdate(tbs_certificate, sizeof(tbs_certificate));
ok = verifier.VerifyFinal();
+#ifndef PURIFY
EXPECT_FALSE(ok);
+#endif
}
}
« no previous file with comments | « no previous file | base/data/purify/base_unittests.exe.gtest.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698