Disable the negative test cases in the test...

Disable the negative test cases in the test
SignatureVerifierTest.BasicTest when running inside Purify
because Purify disables digital signature verification.

R=erikkay
BUG=10031
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13724

[wtc, 2009-04-14 23:59:47]

Thanks for the tip on #ifndef PURIFY.

[Erik does not do reviews, 2009-04-15 00:04:32]

Two random questions:
- Should we disable the positive tests as well?  Or do you think there's value
in exercising the surrounding code?
- Rather than disabling the entire negative tests, maybe we should just disable
the EXPECT_FALSE(ok) lines?  That way we're still at least exercising the code
under purify in these cases.

[wtc, 2009-04-15 00:13:29]

On 2009/04/15 00:04:32, Erik Kay wrote:
> - Should we disable the positive tests as well?  Or do you think there's value
> in exercising the surrounding code?

Yes, I think there is value in exercising the surrounding code.

By the way, I commented out the code in the SignatureVerifier
destructor, but Purify didn't report any leaks of memory or
Windows CryptoAPI handles.  Purify did report a memory leak that
I introduced into the unit test.  So I don't know why Purify didn't
report the leaks related to CryptoAPI.

> - Rather than disabling the entire negative tests, maybe we should just
disable
> the EXPECT_FALSE(ok) lines?  That way we're still at least exercising the code
> under purify in these cases.

I can do that.

[wtc, 2009-04-15 00:19:43]

Please review Patch Set 2.

[Erik does not do reviews, 2009-04-15 00:27:28]

LGTM