app_shell: Initial skeleton of a GCD target device setup API

app_shell: Initial skeleton of a GCD target device setup API

This initial implementation does nothing. Eventually it will talk to privet
and buffet to determine setup state and show progress.

BUG=428853
TEST=app_shell_unittests

Committed: https://crrev.com/914043ab83536a2340fbfb3e66298d43d008a0db
Cr-Commit-Position: refs/heads/master@{#302507}

[James Cook, 2014-10-30 20:43:30]

jamescook@chromium.org changed reviewers:
+ gene@chromium.org, rockot@chromium.org

[James Cook, 2014-10-30 20:43:31]

Gene, can you take a look at the IDL from the "will this information ever be
available" perspective?

Ken, can you take a look from the "did he screw up the extension API definition"
perspective?

[Ken Rockot(use gerrit already), 2014-10-30 20:47:21]

https://codereview.chromium.org/690093002/diff/1/extensions/shell/common/api/...
File extensions/shell/common/api/shell_gcd.idl (right):

https://codereview.chromium.org/690093002/diff/1/extensions/shell/common/api/...
extensions/shell/common/api/shell_gcd.idl:12: bootstrapping,
nit: I think the term "bootstrap" is being overloaded in this enum

https://codereview.chromium.org/690093002/diff/1/extensions/shell/common/api/...
extensions/shell/common/api/shell_gcd.idl:28: static void
GetBootstrapStatus(BootstrapStatusCallback callback);
nit: getBootstrapStatus

[James Cook, 2014-10-30 21:30:50]

https://codereview.chromium.org/690093002/diff/1/extensions/shell/common/api/...
File extensions/shell/common/api/shell_gcd.idl (right):

https://codereview.chromium.org/690093002/diff/1/extensions/shell/common/api/...
extensions/shell/common/api/shell_gcd.idl:12: bootstrapping,
On 2014/10/30 20:47:21, Ken Rockot wrote:
> nit: I think the term "bootstrap" is being overloaded in this enum

Maybe it should be SetupStatus?

I was trying to follow naming conventions from this doc's state diagram:

https://docs.google.com/a/google.com/document/d/1NeVPsiyZe2gjisNdK4Ce_Yb1kpUp...

https://codereview.chromium.org/690093002/diff/1/extensions/shell/common/api/...
extensions/shell/common/api/shell_gcd.idl:28: static void
GetBootstrapStatus(BootstrapStatusCallback callback);
On 2014/10/30 20:47:21, Ken Rockot wrote:
> nit: getBootstrapStatus

Good catch.

[James Cook, 2014-10-30 21:53:13]

Ken, Gene, please take another look.

I added the C++ boilerplate as well.

I'll rename everything if you think SetupStatus / getSetupStatus is a better
naming convention.

[Ken Rockot(use gerrit already), 2014-10-30 22:01:05]

https://codereview.chromium.org/690093002/diff/20001/extensions/shell/common/...
File extensions/shell/common/api/shell_gcd.idl (right):

https://codereview.chromium.org/690093002/diff/20001/extensions/shell/common/...
extensions/shell/common/api/shell_gcd.idl:12: bootstrapping,
The naming is fine in general. All I really meant by "overloaded" is that you
have "bootstrap" referring to the overall bootstrap process, which is complete
when BootstrapStatus is "completed."

But then you also have "connection" being documented as "has bootstrapped",
meaning that the subprocess of wifi bootstrapping has completed.

This is confusing to me. I don't think it's necessary to change
BootstrapStatus/getBootstrapStatus names. Probably just a good idea to clarify
the documentation and maybe reconsider the name of this first state's name (my
strawman suggestions are "initializing", "uninitialized", "disconnected", etc.)

Also everything lgtm so far otherwise, if you need a stamp

[James Cook, 2014-10-30 23:24:57]

Patchset #3 (id:40001) has been deleted

[James Cook, 2014-10-30 23:25:31]

I renamed it to SetupStatus and I like this a lot better.

Gene, if you're OK with this feel free to check the CQ button.

[James Cook, 2014-10-31 20:39:55]

Gene, friendly ping?

[chromium-reviews, 2014-10-31 21:03:13]

Sorry about delay, looking right now :).

On Fri, Oct 31, 2014 at 1:39 PM, <jamescook@chromium.org> wrote:

> Gene, friendly ping?
>
>
> https://codereview.chromium.org/690093002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[James Cook, 2014-10-31 23:06:02]

Patchset #4 (id:80001) has been deleted

[James Cook, 2014-10-31 23:06:44]

Gene, PTAL. I renamed the states like we discussed.

[gene, 2014-11-01 00:15:44]

lgtm!

[James Cook, 2014-11-02 00:21:17]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-11-02 00:22:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/690093002/100001

[commit-bot: I haz the power, 2014-11-02 00:24:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-02 00:24:40]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/76736)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[James Cook, 2014-11-03 18:37:17]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-11-03 18:38:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/690093002/120001

[commit-bot: I haz the power, 2014-11-03 19:28:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-03 19:28:42]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2014-11-03 21:56:18]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-11-03 21:58:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/690093002/140001

[commit-bot: I haz the power, 2014-11-03 22:45:19]

Committed patchset #6 (id:140001)

[commit-bot: I haz the power, 2014-11-03 22:46:08]

Patchset 6 (id:??) landed as
https://crrev.com/914043ab83536a2340fbfb3e66298d43d008a0db
Cr-Commit-Position: refs/heads/master@{#302507}