Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
690083002:
Domain Reliability: Include ERR_ABORTED requests in reports (Closed)
|
Created:
6 years, 1 month ago by Deprecated (see juliatuttle) Modified:
6 years, 1 month ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Project:
chromium Visibility:
Public. |
DescriptionDomain Reliability: Include ERR_ABORTED requests in reports
Many requests that would eventually be timeout errors instead show up
as ERR_ABORTED, so make requests ending in ERR_ABORTED visible to
Domain Reliability collectors.
BUG=
Committed: https://crrev.com/4aa422f5f8ab5baa4c1b76a040a033e9c7e5588d
Cr-Commit-Position: refs/heads/master@{#302312}
Patch Set 1 #
Total comments: 11
Messages
Total messages: 13 (4 generated)
ttuttle@chromium.org changed reviewers: + davidben@chromium.org
ttuttle@chromium.org changed required reviewers: + davidben@chromium.org
PTAL, davidben.
lgtm, though note that this will also catch cancels from other subsystems. E.g. if a SafeBrowsing interstitial is closed, the request is canceled with ERR_ABORTED.
pavlos@chromium.org changed reviewers: + pavlos@chromium.org
Can you add a bunch of error code to the error whitelist? https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... File components/domain_reliability/util.cc (right): https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... components/domain_reliability/util.cc:55: { net::ERR_ADDRESS_UNREACHABLE, "tcp.connection.address_unreachable" }, Can you add: NO_SSL_VERSIONS_ENABLED SSL_VERSION_OR_CIPHER_MISMATCH SSL_RENEGOTIATION_REQUESTED CERT_ERROR_IN_SSL_RENEGOTIATION BAD_SSL_CLIENT_AUTH_CERT https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... components/domain_reliability/util.cc:57: { net::ERR_NAME_RESOLUTION_FAILED, "dns" }, Can you add: NETWORK_ACCESS_DENIED TEMPORARY_THROTTLED MSG_TOO_BIG SPDY_SESSION_ALREADY_EXISTS WS_PROTOCOL_ERROR PROTOCOL_SWITCHED SSL_HANDSHAKE_NOT_COMPLETED SSL_BAD_PEER_PUBLIC_KEY https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... components/domain_reliability/util.cc:59: "ssl.pinned_key_not_in_cert_chain" }, CLIENT_AUTH_CERT_TYPE_UNSUPPORTED ORIGIN_BOUND_CERT_GENERATION_TYPE_MISMATCH SSL_DECRYPT_ERROR_ALERT TOO_MANY_SOCKET_STREAMS SSL_SERVER_CERT_CHANGED SSL_INAPPROPRIATE_FALLBACK CT_NO_SCTS_VERIFIED_OK SSL_UNRECOGNIZED_NAME_ALERT SSL_FALLBACK_BEYOND_MINIMUM_VERSION https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... components/domain_reliability/util.cc:62: { net::ERR_CERT_AUTHORITY_INVALID, "ssl.cert.authority_invalid" }, CERT_NO_REVOCATION_MECHANISM CERT_UNABLE_TO_CHECK_REVOCATION https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... components/domain_reliability/util.cc:64: { net::ERR_CERT_INVALID, "ssl.cert.invalid" }, CERT_WEAK_SIGNATURE_ALGORITHM CERT_NON_UNIQUE_NAME CERT_WEAK_KEY CERT_NAME_CONSTRAINT_VIOLATION https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... components/domain_reliability/util.cc:65: { net::ERR_EMPTY_RESPONSE, "http.empty_response" }, ERR_EMPTY_RESPONSE UNSAFE_REDIRECT INVALID_RESPONSE INVALID_CHUNKED_ENCODING METHOD_NOT_SUPPORTED UNEXPECTED_PROXY_AUTH https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... components/domain_reliability/util.cc:66: { net::ERR_SPDY_PING_FAILED, "spdy.ping_failed" }, RESPONSE_HEADERS_TOO_BIG REQUEST_RANGE_NOT_SATISFIABLE MALFORMED_IDENTITY CONTENT_DECODING_FAILED ENCODING_CONVERSION_FAILED INVALID_SPDY_STREAM https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... components/domain_reliability/util.cc:67: { net::ERR_SPDY_PROTOCOL_ERROR, "spdy.protocol" }, INVALID_AUTH_CREDENTIALS UNSUPPORTED_AUTH_SCHEME ENCODING_DETECTION_FAILED RESPONSE_BODY_TOO_BIG_TO_DRAIN RESPONSE_HEADERS_MULTIPLE_CONTENT_LENGTH INCOMPLETE_SPDY_HEADERS RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION RESPONSE_HEADERS_MULTIPLE_LOCATION SPDY_SERVER_REFUSED_STREAM SPDY_PING_FAILED CONTENT_LENGTH_MISMATCH INCOMPLETE_CHUNKED_ENCODING https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... components/domain_reliability/util.cc:68: { net::ERR_QUIC_PROTOCOL_ERROR, "quic.protocol" }, RESPONSE_HEADERS_TRUNCATED QUIC_HANDSHAKE_FAILED REQUEST_FOR_SECURE_RESOURCE_OVER_INSECURE_QUIC SPDY_INADEQUATE_TRANSPORT_SECURITY SPDY_FLOW_CONTROL_ERROR SPDY_FRAME_SIZE_ERROR SPDY_COMPRESSION_ERROR INSECURE_RESPONSE NO_PRIVATE_KEY_FOR_CERT IMPORT_CA_CERT_FAILED IMPORT_SERVER_CERT_FAILED KEY_GENERATION_FAILED ORIGIN_BOUND_CERT_GENERATION_FAILED https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... components/domain_reliability/util.cc:69: { net::ERR_DNS_MALFORMED_RESPONSE, "dns.protocol" }, DNS_SERVER_REQUIRES_TCP https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... components/domain_reliability/util.cc:71: { net::ERR_DNS_TIMED_OUT, "dns.timed_out" }, DNS_SEARCH_EMPTY DNS_SORT_ERROR
On 2014/10/30 22:25:43, pavlos wrote: > Can you add a bunch of error code to the error whitelist? > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > File components/domain_reliability/util.cc (right): > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > components/domain_reliability/util.cc:55: { net::ERR_ADDRESS_UNREACHABLE, > "tcp.connection.address_unreachable" }, > Can you add: > NO_SSL_VERSIONS_ENABLED > SSL_VERSION_OR_CIPHER_MISMATCH > SSL_RENEGOTIATION_REQUESTED > CERT_ERROR_IN_SSL_RENEGOTIATION > BAD_SSL_CLIENT_AUTH_CERT > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > components/domain_reliability/util.cc:57: { net::ERR_NAME_RESOLUTION_FAILED, > "dns" }, > Can you add: > NETWORK_ACCESS_DENIED > TEMPORARY_THROTTLED > MSG_TOO_BIG > SPDY_SESSION_ALREADY_EXISTS > WS_PROTOCOL_ERROR > PROTOCOL_SWITCHED > SSL_HANDSHAKE_NOT_COMPLETED > SSL_BAD_PEER_PUBLIC_KEY > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > components/domain_reliability/util.cc:59: "ssl.pinned_key_not_in_cert_chain" }, > CLIENT_AUTH_CERT_TYPE_UNSUPPORTED > ORIGIN_BOUND_CERT_GENERATION_TYPE_MISMATCH > SSL_DECRYPT_ERROR_ALERT > TOO_MANY_SOCKET_STREAMS > SSL_SERVER_CERT_CHANGED > SSL_INAPPROPRIATE_FALLBACK > CT_NO_SCTS_VERIFIED_OK > SSL_UNRECOGNIZED_NAME_ALERT > SSL_FALLBACK_BEYOND_MINIMUM_VERSION > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > components/domain_reliability/util.cc:62: { net::ERR_CERT_AUTHORITY_INVALID, > "ssl.cert.authority_invalid" }, > CERT_NO_REVOCATION_MECHANISM > CERT_UNABLE_TO_CHECK_REVOCATION > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > components/domain_reliability/util.cc:64: { net::ERR_CERT_INVALID, > "ssl.cert.invalid" }, > CERT_WEAK_SIGNATURE_ALGORITHM > CERT_NON_UNIQUE_NAME > CERT_WEAK_KEY > CERT_NAME_CONSTRAINT_VIOLATION > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > components/domain_reliability/util.cc:65: { net::ERR_EMPTY_RESPONSE, > "http.empty_response" }, > ERR_EMPTY_RESPONSE > UNSAFE_REDIRECT > INVALID_RESPONSE > INVALID_CHUNKED_ENCODING > METHOD_NOT_SUPPORTED > UNEXPECTED_PROXY_AUTH > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > components/domain_reliability/util.cc:66: { net::ERR_SPDY_PING_FAILED, > "spdy.ping_failed" }, > RESPONSE_HEADERS_TOO_BIG > REQUEST_RANGE_NOT_SATISFIABLE > MALFORMED_IDENTITY > CONTENT_DECODING_FAILED > ENCODING_CONVERSION_FAILED > INVALID_SPDY_STREAM > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > components/domain_reliability/util.cc:67: { net::ERR_SPDY_PROTOCOL_ERROR, > "spdy.protocol" }, > INVALID_AUTH_CREDENTIALS > UNSUPPORTED_AUTH_SCHEME > ENCODING_DETECTION_FAILED > RESPONSE_BODY_TOO_BIG_TO_DRAIN > RESPONSE_HEADERS_MULTIPLE_CONTENT_LENGTH > INCOMPLETE_SPDY_HEADERS > RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION > RESPONSE_HEADERS_MULTIPLE_LOCATION > SPDY_SERVER_REFUSED_STREAM > SPDY_PING_FAILED > CONTENT_LENGTH_MISMATCH > INCOMPLETE_CHUNKED_ENCODING > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > components/domain_reliability/util.cc:68: { net::ERR_QUIC_PROTOCOL_ERROR, > "quic.protocol" }, > RESPONSE_HEADERS_TRUNCATED > QUIC_HANDSHAKE_FAILED > REQUEST_FOR_SECURE_RESOURCE_OVER_INSECURE_QUIC > SPDY_INADEQUATE_TRANSPORT_SECURITY > SPDY_FLOW_CONTROL_ERROR > SPDY_FRAME_SIZE_ERROR > SPDY_COMPRESSION_ERROR > INSECURE_RESPONSE > NO_PRIVATE_KEY_FOR_CERT > IMPORT_CA_CERT_FAILED > IMPORT_SERVER_CERT_FAILED > KEY_GENERATION_FAILED > ORIGIN_BOUND_CERT_GENERATION_FAILED > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > components/domain_reliability/util.cc:69: { net::ERR_DNS_MALFORMED_RESPONSE, > "dns.protocol" }, > DNS_SERVER_REQUIRES_TCP > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > components/domain_reliability/util.cc:71: { net::ERR_DNS_TIMED_OUT, > "dns.timed_out" }, > DNS_SEARCH_EMPTY > DNS_SORT_ERROR That's a *lot* of errors to add; can we focus on a smaller number of more common ones, based on the net error histograms?
On 2014/10/31 19:08:26, ttuttle wrote: > On 2014/10/30 22:25:43, pavlos wrote: > > Can you add a bunch of error code to the error whitelist? > > > > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > > File components/domain_reliability/util.cc (right): > > > > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > > components/domain_reliability/util.cc:55: { net::ERR_ADDRESS_UNREACHABLE, > > "tcp.connection.address_unreachable" }, > > Can you add: > > NO_SSL_VERSIONS_ENABLED > > SSL_VERSION_OR_CIPHER_MISMATCH > > SSL_RENEGOTIATION_REQUESTED > > CERT_ERROR_IN_SSL_RENEGOTIATION > > BAD_SSL_CLIENT_AUTH_CERT > > > > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > > components/domain_reliability/util.cc:57: { net::ERR_NAME_RESOLUTION_FAILED, > > "dns" }, > > Can you add: > > NETWORK_ACCESS_DENIED > > TEMPORARY_THROTTLED > > MSG_TOO_BIG > > SPDY_SESSION_ALREADY_EXISTS > > WS_PROTOCOL_ERROR > > PROTOCOL_SWITCHED > > SSL_HANDSHAKE_NOT_COMPLETED > > SSL_BAD_PEER_PUBLIC_KEY > > > > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > > components/domain_reliability/util.cc:59: "ssl.pinned_key_not_in_cert_chain" > }, > > CLIENT_AUTH_CERT_TYPE_UNSUPPORTED > > ORIGIN_BOUND_CERT_GENERATION_TYPE_MISMATCH > > SSL_DECRYPT_ERROR_ALERT > > TOO_MANY_SOCKET_STREAMS > > SSL_SERVER_CERT_CHANGED > > SSL_INAPPROPRIATE_FALLBACK > > CT_NO_SCTS_VERIFIED_OK > > SSL_UNRECOGNIZED_NAME_ALERT > > SSL_FALLBACK_BEYOND_MINIMUM_VERSION > > > > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > > components/domain_reliability/util.cc:62: { net::ERR_CERT_AUTHORITY_INVALID, > > "ssl.cert.authority_invalid" }, > > CERT_NO_REVOCATION_MECHANISM > > CERT_UNABLE_TO_CHECK_REVOCATION > > > > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > > components/domain_reliability/util.cc:64: { net::ERR_CERT_INVALID, > > "ssl.cert.invalid" }, > > CERT_WEAK_SIGNATURE_ALGORITHM > > CERT_NON_UNIQUE_NAME > > CERT_WEAK_KEY > > CERT_NAME_CONSTRAINT_VIOLATION > > > > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > > components/domain_reliability/util.cc:65: { net::ERR_EMPTY_RESPONSE, > > "http.empty_response" }, > > ERR_EMPTY_RESPONSE > > UNSAFE_REDIRECT > > INVALID_RESPONSE > > INVALID_CHUNKED_ENCODING > > METHOD_NOT_SUPPORTED > > UNEXPECTED_PROXY_AUTH > > > > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > > components/domain_reliability/util.cc:66: { net::ERR_SPDY_PING_FAILED, > > "spdy.ping_failed" }, > > RESPONSE_HEADERS_TOO_BIG > > REQUEST_RANGE_NOT_SATISFIABLE > > MALFORMED_IDENTITY > > CONTENT_DECODING_FAILED > > ENCODING_CONVERSION_FAILED > > INVALID_SPDY_STREAM > > > > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > > components/domain_reliability/util.cc:67: { net::ERR_SPDY_PROTOCOL_ERROR, > > "spdy.protocol" }, > > INVALID_AUTH_CREDENTIALS > > UNSUPPORTED_AUTH_SCHEME > > ENCODING_DETECTION_FAILED > > RESPONSE_BODY_TOO_BIG_TO_DRAIN > > RESPONSE_HEADERS_MULTIPLE_CONTENT_LENGTH > > INCOMPLETE_SPDY_HEADERS > > RESPONSE_HEADERS_MULTIPLE_CONTENT_DISPOSITION > > RESPONSE_HEADERS_MULTIPLE_LOCATION > > SPDY_SERVER_REFUSED_STREAM > > SPDY_PING_FAILED > > CONTENT_LENGTH_MISMATCH > > INCOMPLETE_CHUNKED_ENCODING > > > > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > > components/domain_reliability/util.cc:68: { net::ERR_QUIC_PROTOCOL_ERROR, > > "quic.protocol" }, > > RESPONSE_HEADERS_TRUNCATED > > QUIC_HANDSHAKE_FAILED > > REQUEST_FOR_SECURE_RESOURCE_OVER_INSECURE_QUIC > > SPDY_INADEQUATE_TRANSPORT_SECURITY > > SPDY_FLOW_CONTROL_ERROR > > SPDY_FRAME_SIZE_ERROR > > SPDY_COMPRESSION_ERROR > > INSECURE_RESPONSE > > NO_PRIVATE_KEY_FOR_CERT > > IMPORT_CA_CERT_FAILED > > IMPORT_SERVER_CERT_FAILED > > KEY_GENERATION_FAILED > > ORIGIN_BOUND_CERT_GENERATION_FAILED > > > > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > > components/domain_reliability/util.cc:69: { net::ERR_DNS_MALFORMED_RESPONSE, > > "dns.protocol" }, > > DNS_SERVER_REQUIRES_TCP > > > > > https://codereview.chromium.org/690083002/diff/1/components/domain_reliabilit... > > components/domain_reliability/util.cc:71: { net::ERR_DNS_TIMED_OUT, > > "dns.timed_out" }, > > DNS_SEARCH_EMPTY > > DNS_SORT_ERROR > > That's a *lot* of errors to add; can we focus on a smaller number of more common > ones, based on the net error histograms? (I'm going to land this now, and we can add others in another change if wanted.)
The CQ bit was checked by ttuttle@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690083002/1
> That's a *lot* of errors to add; can we focus on a smaller number of more > common ones, based on the net error histograms? Can you do the cross-reference? Can you send a link to the net error histograms?
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4aa422f5f8ab5baa4c1b76a040a033e9c7e5588d Cr-Commit-Position: refs/heads/master@{#302312} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
